Fix broken patch (#640)

## Bug fixes
- Fixes dying on spawn in Evacuation
- Fixes the player seeing objects loading out when changing star system
- Fixes a NRE on reload without the Stranger

This time without introducing a bug that breaks systems with only a
single planet!

NewHorizons/Builder/General/AstroObjectBuilder.cs

@@ -1,3 +1,4 @@
+using NewHorizons.Components;
 using NewHorizons.Components.Orbital;
 using NewHorizons.External.Configs;
 using NewHorizons.Utility.OWML;
@@ -61,7 +62,9 @@ namespace NewHorizons.Builder.General
                 Delay.RunWhen(
                     () => Locator._centerOfTheUniverse != null,
                     () => Locator._centerOfTheUniverse._staticReferenceFrame = astroObject.GetComponent<OWRigidbody>()
-                    );
+                );
+
+                PreserveActiveCenterOfTheUniverse.Apply(astroObject.gameObject);
             }
 
             return astroObject;

NewHorizons/Builder/Orbital/InitialMotionBuilder.cs

@@ -80,7 +80,7 @@ namespace NewHorizons.Builder.Orbital
             }
             else
             {
-                NHLogger.LogError($"No primary gravity or focal point for {primaryBody}");
+                NHLogger.LogError($"Trying to put {secondaryBody.name} around {primaryBody.name} but found no primary gravity or focal point.");
             }
         }
 

NewHorizons/Components/PreserveActiveCenterOfTheUniverse.cs

@@ -0,0 +1,26 @@
+using NewHorizons.Utility.OWML;
+using UnityEngine;
+
+namespace NewHorizons.Components
+{
+    // Prevents the center of the universe being deactivated
+    public class PreserveActiveCenterOfTheUniverse : MonoBehaviour
+    {
+        private GameObject _centerOfTheUniverse;
+
+        public static void Apply(GameObject center)
+        {
+            var go = new GameObject(nameof(PreserveActiveCenterOfTheUniverse));
+            go.AddComponent<PreserveActiveCenterOfTheUniverse>()._centerOfTheUniverse = center;
+        }
+
+        public void Update()
+        {
+            if (!_centerOfTheUniverse.activeInHierarchy)
+            {
+                NHLogger.LogWarning("Center of the universe cannot be inactive.");
+                _centerOfTheUniverse.SetActive(true);
+            }
+        }
+    }
+}

NewHorizons/Handlers/PlanetCreationHandler.cs

@@ -245,20 +245,10 @@ namespace NewHorizons.Handlers
                     try
                     {
                         NHLogger.Log($"Creating [{body.Config.name}]");
-                        var planetObject = GenerateBody(body, defaultPrimaryToSun);
+                        var planetObject = GenerateBody(body, defaultPrimaryToSun) 
-                        try
+                            ?? throw new NullReferenceException("Something went wrong when generating the body but no errors were logged.");
-                        {
+                        
-                            planetObject?.SetActive(true);
+                        planetObject.SetActive(true);
-                        }
-                        catch (Exception e)
-                        {
-                            NHLogger.LogError($"Error when activating new planet [{body.Config.name}] - {e}");
-                        }
-                        if (planetObject == null) 
-                        { 
-                            body.UnloadCache(); 
-                            return false; 
-                        }
 
                         var ao = planetObject.GetComponent<NHAstroObject>();
 

NewHorizons/manifest.json

@@ -4,7 +4,7 @@
   "author": "xen, Bwc9876, clay, MegaPiggy, John, Trifid, Hawkbar, Book",
   "name": "New Horizons",
   "uniqueName": "xen.NewHorizons",
-  "version": "1.12.3",
+  "version": "1.12.4",
   "owmlVersion": "2.9.3",
   "dependencies": [ "JohnCorby.VanillaFix", "_nebula.MenuFramework", "xen.CommonCameraUtility", "dgarro.CustomShipLogModes" ],
   "conflicts": [ "Raicuparta.QuantumSpaceBuddies", "PacificEngine.OW_CommonResources" ],