## Bug fixes
- Fixes The Vision roasting you in the sun if you're Turkish (use
invariant culture when changing string casing)
This commit is contained in:
xen-42 2024-04-27 20:17:27 -04:00 committed by GitHub
commit e0a28557e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 13 additions and 12 deletions

View File

@ -51,7 +51,7 @@ namespace NewHorizons.Builder.StarSystem
{
if (!tex)
{
NHLogger.LogError($"Failed to load texture for skybox {name.ToLower()} face");
NHLogger.LogError($"Failed to load texture for skybox {name.ToLowerInvariant()} face");
return null;
}

View File

@ -126,11 +126,11 @@ namespace NewHorizons.Handlers
private static bool DetermineIfChildOfFocal(NewHorizonsBody body, FocalPointNode node)
{
var name = body.Config.name.ToLower();
var primary = (body.Config.Orbit?.primaryBody ?? "").ToLower();
var primaryName = node.primary.body.Config.name.ToLower();
var secondaryName = node.secondary.body.Config.name.ToLower();
return name != primaryName && name != secondaryName && (primary == node.body.Config.name.ToLower() || primary == primaryName || primary == secondaryName);
var name = body.Config.name.ToLowerInvariant();
var primary = (body.Config.Orbit?.primaryBody ?? "").ToLowerInvariant();
var primaryName = node.primary.body.Config.name.ToLowerInvariant();
var secondaryName = node.secondary.body.Config.name.ToLowerInvariant();
return name != primaryName && name != secondaryName && (primary == node.body.Config.name.ToLowerInvariant() || primary == primaryName || primary == secondaryName);
}

View File

@ -787,7 +787,7 @@ namespace NewHorizons
{
if (language is TextTranslation.Language.UNKNOWN or TextTranslation.Language.TOTAL) continue;
var relativeFile = Path.Combine("translations", language.ToString().ToLower() + ".json");
var relativeFile = Path.Combine("translations", language.ToString().ToLowerInvariant() + ".json");
if (File.Exists(Path.Combine(folder, relativeFile)))
{

View File

@ -72,14 +72,14 @@ namespace NewHorizons.Utility
public static string ToCamelCase(this string str)
{
StringBuilder strBuilder = new StringBuilder(str);
strBuilder[0] = strBuilder[0].ToString().ToLower().ToCharArray()[0];
strBuilder[0] = strBuilder[0].ToString().ToLowerInvariant().ToCharArray()[0];
return strBuilder.ToString();
}
public static string ToTitleCase(this string str)
{
StringBuilder strBuilder = new StringBuilder(str);
strBuilder[0] = strBuilder[0].ToString().ToUpper().ToCharArray()[0];
strBuilder[0] = strBuilder[0].ToString().ToUpperInvariant().ToCharArray()[0];
return strBuilder.ToString();
}

View File

@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using NewHorizons.Components.Orbital;
using NewHorizons.Handlers;
@ -33,7 +34,7 @@ namespace NewHorizons.Utility.OuterWilds
}
// Else check stock names
var stringID = name.ToUpper().Replace(" ", "_").Replace("'", "");
var stringID = name.ToUpperInvariant().Replace(" ", "_").Replace("'", "");
if (stringID.Equals("ATTLEROCK")) stringID = "TIMBER_MOON";
if (stringID.Equals("HOLLOWS_LANTERN")) stringID = "VOLCANIC_MOON";
if (stringID.Equals("ASH_TWIN")) stringID = "TOWER_TWIN";
@ -42,7 +43,7 @@ namespace NewHorizons.Utility.OuterWilds
if (stringID.Equals("EYE") || stringID.Equals("EYEOFTHEUNIVERSE")) stringID = "EYE_OF_THE_UNIVERSE";
string key;
if (stringID.ToUpper().Replace("_", "").Equals("MAPSATELLITE"))
if (stringID.ToUpperInvariant().Replace("_", "").Equals("MAPSATELLITE"))
{
key = AstroObject.Name.MapSatellite.ToString();
}

View File

@ -4,7 +4,7 @@
"author": "xen, Bwc9876, JohnCorby, MegaPiggy, Clay, Trifid, and friends",
"name": "New Horizons",
"uniqueName": "xen.NewHorizons",
"version": "1.20.0",
"version": "1.20.1",
"owmlVersion": "2.10.3",
"dependencies": [ "JohnCorby.VanillaFix", "xen.CommonCameraUtility", "dgarro.CustomShipLogModes" ],
"conflicts": [ "PacificEngine.OW_CommonResources" ],