From 146966966449874151a39107d6a73f6eb1e1f950 Mon Sep 17 00:00:00 2001 From: Noah Pilarski Date: Sat, 15 Mar 2025 02:43:52 -0400 Subject: [PATCH 1/5] make spawns show up in PlayerSpawner.FindPlanetSpawns --- NewHorizons/Builder/General/SpawnPointBuilder.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NewHorizons/Builder/General/SpawnPointBuilder.cs b/NewHorizons/Builder/General/SpawnPointBuilder.cs index a38802b6..69a75135 100644 --- a/NewHorizons/Builder/General/SpawnPointBuilder.cs +++ b/NewHorizons/Builder/General/SpawnPointBuilder.cs @@ -40,6 +40,7 @@ namespace NewHorizons.Builder.General foreach (var point in module.playerSpawnPoints) { GameObject spawnGO = GeneralPropBuilder.MakeNew("PlayerSpawnPoint", planetGO, null, point); + spawnGO.SetActive(false); spawnGO.layer = Layer.PlayerSafetyCollider; playerSpawn = spawnGO.AddComponent(); @@ -69,6 +70,8 @@ namespace NewHorizons.Builder.General PlayerSpawn = playerSpawn; PlayerSpawnInfo = point; } + + spawnGO.SetActive(true); } } From cc73e40fd959d88ab2927a3cba1d0771ea9888e3 Mon Sep 17 00:00:00 2001 From: Noah Pilarski Date: Sat, 15 Mar 2025 02:46:55 -0400 Subject: [PATCH 2/5] no need for this as it is already inactive --- NewHorizons/Builder/General/SpawnPointBuilder.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/NewHorizons/Builder/General/SpawnPointBuilder.cs b/NewHorizons/Builder/General/SpawnPointBuilder.cs index 69a75135..a5e8700d 100644 --- a/NewHorizons/Builder/General/SpawnPointBuilder.cs +++ b/NewHorizons/Builder/General/SpawnPointBuilder.cs @@ -40,7 +40,6 @@ namespace NewHorizons.Builder.General foreach (var point in module.playerSpawnPoints) { GameObject spawnGO = GeneralPropBuilder.MakeNew("PlayerSpawnPoint", planetGO, null, point); - spawnGO.SetActive(false); spawnGO.layer = Layer.PlayerSafetyCollider; playerSpawn = spawnGO.AddComponent(); @@ -80,7 +79,6 @@ namespace NewHorizons.Builder.General foreach (var point in module.shipSpawnPoints) { var spawnGO = GeneralPropBuilder.MakeNew("ShipSpawnPoint", planetGO, null, point); - spawnGO.SetActive(false); spawnGO.layer = Layer.PlayerSafetyCollider; var shipSpawn = spawnGO.AddComponent(); From bbd1a9575b6749563bcdf19507179b50fb963900 Mon Sep 17 00:00:00 2001 From: Ben C Date: Sat, 15 Mar 2025 08:05:52 -0400 Subject: [PATCH 3/5] Fix Build Workflow --- .github/workflows/build.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5a040682..24526478 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -62,8 +62,7 @@ jobs: name: NewHorizons-Schemas-${{ inputs.build_type }} path: .\NewHorizons\Schemas - - name: Verify Changed Schemas - uses: tj-actions/verify-changed-files@v20 + - name: Check Changed Schemas id: changed_files - with: - files: NewHorizons/Schemas/** + run: | + echo "files_changed=$(git diff --exit-code NewHorizons/Schemas >/dev/null 2>&1 && echo false || echo true)" >> $GITHUB_OUTPUT From 69c2c780b8b0ab369d00fe9203466ea20d4ca54a Mon Sep 17 00:00:00 2001 From: Ben C Date: Sat, 15 Mar 2025 08:12:27 -0400 Subject: [PATCH 4/5] Powershell moment --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 24526478..fb6717da 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -65,4 +65,4 @@ jobs: - name: Check Changed Schemas id: changed_files run: | - echo "files_changed=$(git diff --exit-code NewHorizons/Schemas >/dev/null 2>&1 && echo false || echo true)" >> $GITHUB_OUTPUT + echo "files_changed=$(git diff --exit-code NewHorizons/Schemas 2>&1>$null && echo false || echo true)" >> $GITHUB_OUTPUT From d811b06f163147a55a0674229797b5b200aaf634 Mon Sep 17 00:00:00 2001 From: Ben C Date: Sat, 15 Mar 2025 08:20:52 -0400 Subject: [PATCH 5/5] Powershell moment 2 --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index fb6717da..49c55427 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -65,4 +65,4 @@ jobs: - name: Check Changed Schemas id: changed_files run: | - echo "files_changed=$(git diff --exit-code NewHorizons/Schemas 2>&1>$null && echo false || echo true)" >> $GITHUB_OUTPUT + echo "files_changed=$(git diff --exit-code NewHorizons/Schemas 2>&1>$null && echo false || echo true)" >> $Env:GITHUB_OUTPUT \ No newline at end of file