From d40ede9984d5530637a060ef751781672597ef6c Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Thu, 28 Jul 2022 18:34:29 -0700 Subject: [PATCH] use faster ContainsKey --- NewHorizons/Main.cs | 8 ++++---- NewHorizons/Utility/AstroObjectLocator.cs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NewHorizons/Main.cs b/NewHorizons/Main.cs index ec7d8582..4e77b195 100644 --- a/NewHorizons/Main.cs +++ b/NewHorizons/Main.cs @@ -47,7 +47,7 @@ namespace NewHorizons public static bool IsSystemReady { get; private set; } public static float FurthestOrbit { get; set; } = 50000f; - public string DefaultStarSystem => SystemDict.Keys.Contains(_defaultSystemOverride) ? _defaultSystemOverride : _defaultStarSystem; + public string DefaultStarSystem => SystemDict.ContainsKey(_defaultSystemOverride) ? _defaultSystemOverride : _defaultStarSystem; public string CurrentStarSystem => _currentStarSystem; public bool IsWarpingFromShip { get; private set; } = false; public bool IsWarpingFromVessel { get; private set; } = false; @@ -99,7 +99,7 @@ namespace NewHorizons _defaultSystemOverride = config.GetSettingsValue("Default System Override"); // Else it doesn't get set idk - if (currentScene == "TitleScreen" && SystemDict.Keys.Contains(_defaultSystemOverride)) + if (currentScene == "TitleScreen" && SystemDict.ContainsKey(_defaultSystemOverride)) { _currentStarSystem = _defaultSystemOverride; } @@ -332,7 +332,7 @@ namespace NewHorizons { // Reset back to original solar system after going to main menu. // If the override is a valid system then we go there - if (SystemDict.Keys.Contains(_defaultSystemOverride)) + if (SystemDict.ContainsKey(_defaultSystemOverride)) { _currentStarSystem = _defaultSystemOverride; IsWarpingFromShip = true; // always do this else sometimes the spawn gets messed up @@ -575,7 +575,7 @@ namespace NewHorizons if (!IsChangingStarSystem) { // If the override is a valid system then we go there - if (SystemDict.Keys.Contains(_defaultSystemOverride)) + if (SystemDict.ContainsKey(_defaultSystemOverride)) { _currentStarSystem = _defaultSystemOverride; IsWarpingFromShip = true; // always do this else sometimes the spawn gets messed up diff --git a/NewHorizons/Utility/AstroObjectLocator.cs b/NewHorizons/Utility/AstroObjectLocator.cs index d0bd3231..d28b225e 100644 --- a/NewHorizons/Utility/AstroObjectLocator.cs +++ b/NewHorizons/Utility/AstroObjectLocator.cs @@ -61,7 +61,7 @@ namespace NewHorizons.Utility { var key = ao._name == AstroObject.Name.CustomString ? ao.GetCustomName() : ao._name.ToString(); - if (_customAstroObjectDictionary.Keys.Contains(key)) + if (_customAstroObjectDictionary.ContainsKey(key)) { Logger.LogWarning($"Registering duplicate [{ao.name}] as [{key}]"); _customAstroObjectDictionary[key] = ao;