From 8c16a50989a6b814210a271f52924a5661b99e18 Mon Sep 17 00:00:00 2001 From: Noah Pilarski Date: Sun, 14 Aug 2022 16:44:30 -0400 Subject: [PATCH 1/4] Change default cloud rotation speed --- NewHorizons/Builder/Atmosphere/CloudsBuilder.cs | 13 ++++++++----- NewHorizons/External/Modules/AtmosphereModule.cs | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs b/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs index 53531d86..ea439e0b 100644 --- a/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs @@ -210,11 +210,14 @@ namespace NewHorizons.Builder.Atmosphere cloudsTopGO.layer = LayerMask.NameToLayer("IgnoreSun"); } - RotateTransform topRT = cloudsTopGO.AddComponent(); - // Idk why but the axis is weird - topRT._localAxis = atmo.clouds.cloudsPrefab == CloudPrefabType.Basic ? Vector3.forward : Vector3.up; - topRT._degreesPerSecond = atmo.clouds.rotationSpeed; - topRT._randomizeRotationRate = false; + if (atmo.clouds.rotationSpeed != 0f) + { + RotateTransform topRT = cloudsTopGO.AddComponent(); + // Idk why but the axis is weird + topRT._localAxis = atmo.clouds.cloudsPrefab == CloudPrefabType.Basic ? Vector3.forward : Vector3.up; + topRT._degreesPerSecond = atmo.clouds.rotationSpeed; + topRT._randomizeRotationRate = false; + } cloudsTopGO.transform.localPosition = Vector3.zero; diff --git a/NewHorizons/External/Modules/AtmosphereModule.cs b/NewHorizons/External/Modules/AtmosphereModule.cs index 2e96d20f..54e9af93 100644 --- a/NewHorizons/External/Modules/AtmosphereModule.cs +++ b/NewHorizons/External/Modules/AtmosphereModule.cs @@ -167,7 +167,7 @@ namespace NewHorizons.External.Modules /// /// How fast the clouds will rotate in degrees per second. /// - [DefaultValue(10f)] public float rotationSpeed = 10f; + [DefaultValue(0f)] public float rotationSpeed = 0f; #region Obsolete From 3ca479a5afee2d32e03bfc1f0e871403bb64738b Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sun, 14 Aug 2022 20:47:43 +0000 Subject: [PATCH 2/4] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index aecdc6be..bee1081b 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -366,7 +366,7 @@ "type": "number", "description": "How fast the clouds will rotate in degrees per second.", "format": "float", - "default": 10.0 + "default": 0.0 } } }, From f1b311f246475ef32cb86bf4ada6628c5ebb3498 Mon Sep 17 00:00:00 2001 From: Noah Pilarski Date: Sun, 14 Aug 2022 16:53:31 -0400 Subject: [PATCH 3/4] clarify --- NewHorizons/External/Modules/AtmosphereModule.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/External/Modules/AtmosphereModule.cs b/NewHorizons/External/Modules/AtmosphereModule.cs index 54e9af93..f75e4bed 100644 --- a/NewHorizons/External/Modules/AtmosphereModule.cs +++ b/NewHorizons/External/Modules/AtmosphereModule.cs @@ -165,7 +165,7 @@ namespace NewHorizons.External.Modules public bool unlit; /// - /// How fast the clouds will rotate in degrees per second. + /// How fast the clouds will rotate relative to the planet in degrees per second. /// [DefaultValue(0f)] public float rotationSpeed = 0f; From 1f982e423e6f0aa95262293ff90d4aaf862f89d3 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sun, 14 Aug 2022 20:55:13 +0000 Subject: [PATCH 4/4] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index bee1081b..9a23d4df 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -364,7 +364,7 @@ }, "rotationSpeed": { "type": "number", - "description": "How fast the clouds will rotate in degrees per second.", + "description": "How fast the clouds will rotate relative to the planet in degrees per second.", "format": "float", "default": 0.0 }