Gittes-archive/new-horizons
2
0
Fork 0
mirror of https://github.com/Outer-Wilds-New-Horizons/new-horizons.git synced 2025-12-11 20:15:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

just to exception tostring instead of printing message then stacktrace like gofy

Browse Source
This commit is contained in:
JohnCorby 2022-07-25 16:19:49 -07:00
parent a25ab6375f
commit bef2a32cef
17 changed files with 208 additions and 208 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
NewHorizons/Builder/Atmosphere/CloudsBuilder.cs
View File

@ -96,7 +96,7 @@ namespace NewHorizons.Builder.Atmosphere
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't parse fluid volume type [{atmo.clouds.fluidType}]: {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't parse fluid volume type [{atmo.clouds.fluidType}]:\n{ex}");
} }
fluidCLFV._fluidType = fluidType; fluidCLFV._fluidType = fluidType;
@ -159,7 +159,7 @@ namespace NewHorizons.Builder.Atmosphere
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't load Cloud textures for [{atmo.clouds.texturePath}], {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't load Cloud textures for [{atmo.clouds.texturePath}]:\n{e}");
return null; return null;
} }

2
NewHorizons/Builder/Body/HeightMapBuilder.cs
View File

@ -46,7 +46,7 @@ namespace NewHorizons.Builder.Body
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't load HeightMap textures, {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't load HeightMap textures:\n{e}");
return; return;
} }

2
NewHorizons/Builder/Body/ProxyBuilder.cs
View File

@ -144,7 +144,7 @@ namespace NewHorizons.Builder.Body
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Exception thrown when generating proxy for [{body.Config.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Exception thrown when generating proxy for [{body.Config.name}]:\n{ex}");
GameObject.Destroy(newProxy); GameObject.Destroy(newProxy);
} }
} }

4
NewHorizons/Builder/Body/RingBuilder.cs
View File

@ -54,7 +54,7 @@ namespace NewHorizons.Builder.Body
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't parse fluid volume type [{ring.fluidType}]: {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't parse fluid volume type [{ring.fluidType}]:\n{ex}");
} }
sfv._fluidType = fluidType; sfv._fluidType = fluidType;
@ -79,7 +79,7 @@ namespace NewHorizons.Builder.Body
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't load Ring texture, {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't load Ring texture:\n{e}");
return null; return null;
} }

4
NewHorizons/Builder/Props/DetailBuilder.cs
View File

@ -181,7 +181,7 @@ namespace NewHorizons.Builder.Props
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't update AnglerFish chase speed: {e.Message}"); Logger.LogError($"Couldn't update AnglerFish chase speed:\n{e}");
} }
} }
@ -261,7 +261,7 @@ namespace NewHorizons.Builder.Props
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogWarning($"Exception when modifying component [{component.GetType().Name}] on [{planetGO.name}] for prop [{prefab.name}] : {e.GetType().FullName} {e.Message} {e.StackTrace}"); Logger.LogWarning($"Exception when modifying component [{component.GetType().Name}] on [{planetGO.name}] for prop [{prefab.name}]:\n{e}");
} }
}); });
} }

364
NewHorizons/Builder/Props/PropBuildManager.cs
View File

@ -1,169 +1,169 @@
using NewHorizons.Builder.Body; using NewHorizons.Builder.Body;
using NewHorizons.Builder.ShipLog; using NewHorizons.Builder.ShipLog;
using NewHorizons.External.Configs; using NewHorizons.External.Configs;
using OWML.Common; using OWML.Common;
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using UnityEngine; using UnityEngine;
using Logger = NewHorizons.Utility.Logger; using Logger = NewHorizons.Utility.Logger;
namespace NewHorizons.Builder.Props namespace NewHorizons.Builder.Props
{ {
public static class PropBuildManager public static class PropBuildManager
{ {
public static void Make(GameObject go, Sector sector, OWRigidbody planetBody, PlanetConfig config, IModBehaviour mod) public static void Make(GameObject go, Sector sector, OWRigidbody planetBody, PlanetConfig config, IModBehaviour mod)
{ {
if (config.Props.scatter != null) if (config.Props.scatter != null)
{ {
try try
{ {
ScatterBuilder.Make(go, sector, config, mod); ScatterBuilder.Make(go, sector, config, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make planet scatter for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make planet scatter for [{go.name}]:\n{ex}");
} }
} }
if (config.Props.details != null) if (config.Props.details != null)
{ {
foreach (var detail in config.Props.details) foreach (var detail in config.Props.details)
{ {
try try
{ {
DetailBuilder.Make(go, sector, config, mod, detail); DetailBuilder.Make(go, sector, config, mod, detail);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make planet detail [{detail.path}] for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make planet detail [{detail.path}] for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.geysers != null) if (config.Props.geysers != null)
{ {
foreach (var geyserInfo in config.Props.geysers) foreach (var geyserInfo in config.Props.geysers)
{ {
try try
{ {
GeyserBuilder.Make(go, sector, geyserInfo); GeyserBuilder.Make(go, sector, geyserInfo);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make geyser for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make geyser for [{go.name}]:\n{ex}");
} }
} }
} }
if (Main.HasDLC && config.Props.rafts != null) if (Main.HasDLC && config.Props.rafts != null)
{ {
foreach (var raftInfo in config.Props.rafts) foreach (var raftInfo in config.Props.rafts)
{ {
try try
{ {
RaftBuilder.Make(go, sector, raftInfo, planetBody); RaftBuilder.Make(go, sector, raftInfo, planetBody);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make raft for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make raft for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.tornados != null) if (config.Props.tornados != null)
{ {
foreach (var tornadoInfo in config.Props.tornados) foreach (var tornadoInfo in config.Props.tornados)
{ {
try try
{ {
TornadoBuilder.Make(go, sector, tornadoInfo, config.Atmosphere?.clouds != null); TornadoBuilder.Make(go, sector, tornadoInfo, config.Atmosphere?.clouds != null);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make tornado for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make tornado for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.volcanoes != null) if (config.Props.volcanoes != null)
{ {
foreach (var volcanoInfo in config.Props.volcanoes) foreach (var volcanoInfo in config.Props.volcanoes)
{ {
try try
{ {
VolcanoBuilder.Make(go, sector, volcanoInfo); VolcanoBuilder.Make(go, sector, volcanoInfo);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make volcano for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make volcano for [{go.name}]:\n{ex}");
} }
} }
} }
// Reminder that dialogue has to be built after props if they're going to be using CharacterAnimController stuff // Reminder that dialogue has to be built after props if they're going to be using CharacterAnimController stuff
if (config.Props.dialogue != null) if (config.Props.dialogue != null)
{ {
foreach (var dialogueInfo in config.Props.dialogue) foreach (var dialogueInfo in config.Props.dialogue)
{ {
try try
{ {
DialogueBuilder.Make(go, sector, dialogueInfo, mod); DialogueBuilder.Make(go, sector, dialogueInfo, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make dialogue [{dialogueInfo.xmlFile}] for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make dialogue [{dialogueInfo.xmlFile}] for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.reveal != null) if (config.Props.reveal != null)
{ {
foreach (var revealInfo in config.Props.reveal) foreach (var revealInfo in config.Props.reveal)
{ {
try try
{ {
RevealBuilder.Make(go, sector, revealInfo, mod); RevealBuilder.Make(go, sector, revealInfo, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make reveal location [{revealInfo.reveals}] for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make reveal location [{revealInfo.reveals}] for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.entryLocation != null) if (config.Props.entryLocation != null)
{ {
foreach (var entryLocationInfo in config.Props.entryLocation) foreach (var entryLocationInfo in config.Props.entryLocation)
{ {
try try
{ {
EntryLocationBuilder.Make(go, sector, entryLocationInfo, mod); EntryLocationBuilder.Make(go, sector, entryLocationInfo, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make entry location [{entryLocationInfo.id}] for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make entry location [{entryLocationInfo.id}] for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.nomaiText != null) if (config.Props.nomaiText != null)
{ {
foreach (var nomaiTextInfo in config.Props.nomaiText) foreach (var nomaiTextInfo in config.Props.nomaiText)
{ {
try try
{ {
NomaiTextBuilder.Make(go, sector, nomaiTextInfo, mod); NomaiTextBuilder.Make(go, sector, nomaiTextInfo, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make text [{nomaiTextInfo.xmlFile}] for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make text [{nomaiTextInfo.xmlFile}] for [{go.name}]:\n{ex}");
} }
} }
} }
if (Main.HasDLC && config.Props.slideShows != null) if (Main.HasDLC && config.Props.slideShows != null)
{ {
foreach (var slideReelInfo in config.Props.slideShows) foreach (var slideReelInfo in config.Props.slideShows)
{ {
try try
{ {
ProjectionBuilder.Make(go, sector, slideReelInfo, mod); ProjectionBuilder.Make(go, sector, slideReelInfo, mod);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make slide reel for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make slide reel for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.quantumGroups != null) if (config.Props.quantumGroups != null)
{ {
@ -181,28 +181,28 @@ namespace NewHorizons.Builder.Props
{ {
if (!propsByGroup.ContainsKey(quantumGroup.id)) continue; if (!propsByGroup.ContainsKey(quantumGroup.id)) continue;
var propsInGroup = propsByGroup[quantumGroup.id]; var propsInGroup = propsByGroup[quantumGroup.id];
try try
{ {
QuantumBuilder.Make(go, sector, config, mod, quantumGroup, propsInGroup.ToArray()); QuantumBuilder.Make(go, sector, config, mod, quantumGroup, propsInGroup.ToArray());
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make quantum group \"{quantumGroup.id}\" for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make quantum group \"{quantumGroup.id}\" for [{go.name}]:\n{ex}");
} }
} }
} }
if (config.Props.singularities != null) if (config.Props.singularities != null)
{ {
foreach (var singularity in config.Props.singularities) foreach (var singularity in config.Props.singularities)
{ {
try try
{ {
SingularityBuilder.Make(go, sector, go.GetComponent<OWRigidbody>(), config, singularity); SingularityBuilder.Make(go, sector, go.GetComponent<OWRigidbody>(), config, singularity);
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make singularity \"{(string.IsNullOrEmpty(singularity.uniqueID) ? config.name : singularity.uniqueID)}\" for [{go.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make singularity \"{(string.IsNullOrEmpty(singularity.uniqueID) ? config.name : singularity.uniqueID)}\" for [{go.name}]::\n{ex}");
} }
} }
} }
@ -219,7 +219,7 @@ namespace NewHorizons.Builder.Props
{ {
SignalBuilder.Make(go, sector, signal, mod); SignalBuilder.Make(go, sector, signal, mod);
} }
} }
} }
} }
} }

2
NewHorizons/Components/Orbital/NHOrbitLine.cs
View File

@ -85,7 +85,7 @@ namespace NewHorizons.Components.Orbital
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Exception in OrbitLine for [{_astroObject?.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Exception in OrbitLine for [{_astroObject?.name}]:\n{ex}");
enabled = false; enabled = false;
} }
} }

2
NewHorizons/Components/Orbital/TrackingOrbitLine.cs
View File

@ -85,7 +85,7 @@ namespace NewHorizons.Components.Orbital
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Exception in OrbitLine for [{_astroObject?.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Exception in OrbitLine for [{_astroObject?.name}]:\n{ex}");
enabled = false; enabled = false;
} }
} }

2
NewHorizons/External/NewHorizonsData.cs vendored
View File

@ -41,7 +41,7 @@ namespace NewHorizons.External
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't create save data {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't create save data:\n{e}");
} }
} }
} }

2
NewHorizons/Handlers/AudioTypeHandler.cs
View File

@ -51,7 +51,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't load AudioType {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't load AudioType:\n{e}");
return AudioType.None; return AudioType.None;
} }
} }

8
NewHorizons/Handlers/PlanetCreationHandler.cs
View File

@ -194,7 +194,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't make quantum state for [{body.Config.name}] : {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't make quantum state for [{body.Config.name}]:\n{ex}");
return false; return false;
} }
} }
@ -205,7 +205,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't update body {body.Config?.name}: {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't update body {body.Config?.name}:\n{e}");
return false; return false;
} }
} }
@ -234,7 +234,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't generate body {body.Config?.name}: {e.Message}, {e.StackTrace}"); Logger.LogError($"Couldn't generate body {body.Config?.name}:\n{e}");
return false; return false;
} }
} }
@ -669,7 +669,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't update orbit of [{body.Config.name}]: {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't update orbit of [{body.Config.name}]:\n{ex}");
// If it doesn't work here there's no point trying again so we'll still return true // If it doesn't work here there's no point trying again so we'll still return true
} }

2
NewHorizons/Handlers/PlanetDestructionHandler.cs
View File

@ -173,7 +173,7 @@ namespace NewHorizons.Handlers
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Exception thrown when trying to delete bodies related to [{ao.name}]: {e.Message}, {e.StackTrace}"); Logger.LogError($"Exception thrown when trying to delete bodies related to [{ao.name}]:\n{e}");
} }
// Deal with proxies // Deal with proxies

6
NewHorizons/Main.cs
View File

@ -318,7 +318,7 @@ namespace NewHorizons
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Exception thrown when invoking star system loaded event with parameter [{Instance.CurrentStarSystem}] : {e.GetType().FullName} {e.Message} {e.StackTrace}"); Logger.LogError($"Exception thrown when invoking star system loaded event with parameter [{Instance.CurrentStarSystem}]:\n{e}");
} }
} }
else else
@ -441,7 +441,7 @@ namespace NewHorizons
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"{ex.Message}, {ex.StackTrace}"); Logger.LogError(ex.ToString());
} }
} }
@ -512,7 +512,7 @@ namespace NewHorizons
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Error encounter when loading {relativePath}: {e.Message} {e.StackTrace}"); Logger.LogError($"Error encounter when loading {relativePath}:\n{e}");
} }
return body; return body;

4
NewHorizons/NewHorizonsApi.cs
View File

@ -50,7 +50,7 @@ namespace NewHorizons
} }
catch(Exception ex) catch(Exception ex)
{ {
Logger.LogError($"Error in Create API: {ex.Message} {ex.StackTrace}"); Logger.LogError($"Error in Create API:\n{ex}");
} }
} }
@ -103,7 +103,7 @@ namespace NewHorizons
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.LogError($"Couldn't get installed addons {ex.Message}, {ex.StackTrace}"); Logger.LogError($"Couldn't get installed addons:\n{ex}");
return new string[] { }; return new string[] { };
} }
} }

2
NewHorizons/Utility/AssetBundleUtilities.cs
View File

@ -49,7 +49,7 @@ namespace NewHorizons.Utility
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Couldn't load asset {pathInBundle} from AssetBundle {assetBundleRelativeDir} : {e.Message}"); Logger.LogError($"Couldn't load asset {pathInBundle} from AssetBundle {assetBundleRelativeDir}:\n{e}");
return null; return null;
} }

4
NewHorizons/Utility/DebugMenu/DebugMenu.cs
View File

@ -240,7 +240,7 @@ namespace NewHorizons.Utility.DebugMenu
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Failed to save file {relativePath}:\n{e.Message}\n{e.StackTrace}"); Logger.LogError($"Failed to save file {relativePath}:\n{e}");
} }
try try
@ -253,7 +253,7 @@ namespace NewHorizons.Utility.DebugMenu
} }
catch (Exception e) catch (Exception e)
{ {
Logger.LogError($"Failed to save backup file {backupFolderName}{relativePath}:\n{e.Message}\n{e.StackTrace}"); Logger.LogError($"Failed to save backup file {backupFolderName}{relativePath}:\n{e}");
} }
} }
} }

2
NewHorizons/Utility/ImageUtilities.cs
View File

@ -45,7 +45,7 @@ namespace NewHorizons.Utility
catch (Exception ex) catch (Exception ex)
{ {
// Half the time when a texture doesn't load it doesn't need to exist so just log verbose // Half the time when a texture doesn't load it doesn't need to exist so just log verbose
Logger.LogVerbose($"Exception thrown while loading texture [{filename}]: {ex.Message}, {ex.StackTrace}"); Logger.LogVerbose($"Exception thrown while loading texture [{filename}]:\n{ex}");
return null; return null;
} }
} }