From b5538f7627a788f337eb41e9398a6b3f92595cb1 Mon Sep 17 00:00:00 2001 From: Joshua Thome Date: Wed, 29 Jan 2025 19:56:55 -0600 Subject: [PATCH] Remove vestigial name property from traveler info --- NewHorizons/Builder/Props/EyeOfTheUniverseBuilder.cs | 9 ++------- .../Modules/Props/EyeOfTheUniverse/EyeTravelerInfo.cs | 5 ----- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/NewHorizons/Builder/Props/EyeOfTheUniverseBuilder.cs b/NewHorizons/Builder/Props/EyeOfTheUniverseBuilder.cs index 1e7b3e16..743c149f 100644 --- a/NewHorizons/Builder/Props/EyeOfTheUniverseBuilder.cs +++ b/NewHorizons/Builder/Props/EyeOfTheUniverseBuilder.cs @@ -37,11 +37,6 @@ namespace NewHorizons.Builder.Props var go = DetailBuilder.Make(planetGO, sector, nhBody.Mod, info); - if (string.IsNullOrEmpty(info.name)) - { - info.name = go.name; - } - var travelerController = go.GetAddComponent(); if (!string.IsNullOrEmpty(info.startPlayingCondition)) { @@ -90,7 +85,7 @@ namespace NewHorizons.Builder.Props { if (string.IsNullOrEmpty(info.signal.name)) { - info.signal.name = info.name; + info.signal.name = go.name; } if (string.IsNullOrEmpty(info.signal.frequency)) { @@ -181,7 +176,7 @@ namespace NewHorizons.Builder.Props { if (string.IsNullOrEmpty(info.signal.name)) { - info.signal.name = travelerData.info.name; + info.signal.name = travelerData.info.signal.name; } if (string.IsNullOrEmpty(info.signal.audio)) { diff --git a/NewHorizons/External/Modules/Props/EyeOfTheUniverse/EyeTravelerInfo.cs b/NewHorizons/External/Modules/Props/EyeOfTheUniverse/EyeTravelerInfo.cs index e917f839..82f5abe8 100644 --- a/NewHorizons/External/Modules/Props/EyeOfTheUniverse/EyeTravelerInfo.cs +++ b/NewHorizons/External/Modules/Props/EyeOfTheUniverse/EyeTravelerInfo.cs @@ -12,11 +12,6 @@ namespace NewHorizons.External.Modules.Props.EyeOfTheUniverse /// public string id; - /// - /// The name to display for this traveler's signals. Defaults to the name of the detail. - /// - public string name; - /// /// If set, the player must know this ship log fact for this traveler (and their instrument zones and quantum instruments) to appear. The fact does not need to exist in the current star system; the player's save data will be checked directly. ///