Gittes-archive/new-horizons
2
0
Fork 0
mirror of https://github.com/Outer-Wilds-New-Horizons/new-horizons.git synced 2025-12-11 20:15:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Include sector in the key for detail cache (#431)

Browse Source 
## Bug fixes
- Should fix sector issues with details that are placed on multiple
planets
This commit is contained in:
Nick 2022-10-20 21:35:53 -04:00 committed by GitHub
commit ae3bca5293
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
NewHorizons/Builder/Props/DetailBuilder.cs
View File

@ -15,7 +15,7 @@ namespace NewHorizons.Builder.Props
public static class DetailBuilder public static class DetailBuilder
{ {
private static readonly Dictionary<PropModule.DetailInfo, GameObject> _detailInfoToCorrespondingSpawnedGameObject = new(); private static readonly Dictionary<PropModule.DetailInfo, GameObject> _detailInfoToCorrespondingSpawnedGameObject = new();
private static readonly Dictionary<string, (GameObject prefab, bool isItem)> _fixedPrefabCache = new(); private static readonly Dictionary<(Sector, string), (GameObject prefab, bool isItem)> _fixedPrefabCache = new();
static DetailBuilder() static DetailBuilder()
{ {
@ -82,7 +82,7 @@ namespace NewHorizons.Builder.Props
bool isItem; bool isItem;
// We save copies with all their components fixed, good if the user is placing the same detail more than once // We save copies with all their components fixed, good if the user is placing the same detail more than once
if (detail?.path != null && _fixedPrefabCache.TryGetValue(detail.path, out var storedPrefab)) if (detail?.path != null && _fixedPrefabCache.TryGetValue((sector, detail.path), out var storedPrefab))
{ {
prop = storedPrefab.prefab.InstantiateInactive(); prop = storedPrefab.prefab.InstantiateInactive();
prop.name = prefab.name; prop.name = prefab.name;
@ -114,7 +114,7 @@ namespace NewHorizons.Builder.Props
if (detail.path != null) if (detail.path != null)
{ {
_fixedPrefabCache.Add(detail.path, (prop.InstantiateInactive(), isItem)); _fixedPrefabCache.Add((sector, detail.path), (prop.InstantiateInactive(), isItem));
} }
} }