From acadcc830033d1fc4eb8847cbeafc0768f4c35e0 Mon Sep 17 00:00:00 2001 From: Nick Date: Thu, 24 Aug 2023 14:11:42 -0400 Subject: [PATCH] Don't make hasRain obsolete --- NewHorizons/Builder/Atmosphere/AirBuilder.cs | 1 - NewHorizons/External/Modules/AtmosphereModule.cs | 12 +++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/NewHorizons/Builder/Atmosphere/AirBuilder.cs b/NewHorizons/Builder/Atmosphere/AirBuilder.cs index 8f7767df..8d502f88 100644 --- a/NewHorizons/Builder/Atmosphere/AirBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/AirBuilder.cs @@ -57,7 +57,6 @@ namespace NewHorizons.Builder.Atmosphere airGO.AddComponent()._treeVolume = config.Atmosphere.hasTrees; } - // TODO: figure out what to change "config.Atmosphere.hasRain" to... if (config.Atmosphere.hasRain) { var vref = airGO.AddComponent(); diff --git a/NewHorizons/External/Modules/AtmosphereModule.cs b/NewHorizons/External/Modules/AtmosphereModule.cs index d0665941..4fa3cfe5 100644 --- a/NewHorizons/External/Modules/AtmosphereModule.cs +++ b/NewHorizons/External/Modules/AtmosphereModule.cs @@ -74,6 +74,13 @@ namespace NewHorizons.External.Modules /// public bool hasTrees; + /// + /// Does this planet have rain? + /// This is equivalent to effects of setting a rain vection field, rain audio volume, and visor effect volume, combined for convenience. + /// For more control over the rain, use those individual components. + /// + public bool hasRain; + /// /// Scale height of the atmosphere /// @@ -163,7 +170,6 @@ namespace NewHorizons.External.Modules /// How fast the clouds will rotate relative to the planet in degrees per second. /// [DefaultValue(0f)] public float rotationSpeed = 0f; - #region Obsolete @@ -179,10 +185,6 @@ namespace NewHorizons.External.Modules #region Obsolete - - [Obsolete("HasRain is deprecated, please use VectionFields instead")] - public bool hasRain; - [Obsolete("HasSnow is deprecated, please use VectionFields instead")] public bool hasSnow;