Gittes-archive/new-horizons
2
0
Fork 0
mirror of https://github.com/Outer-Wilds-New-Horizons/new-horizons.git synced 2025-12-11 20:15:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

improve SearchUtilities.Find (#341)

Browse Source 
writes it as a 3-strategy process, since that's effectively what it is. makes it so that not finding the root wont immediately return null
This commit is contained in:
Noah 2022-09-02 07:39:15 -04:00 committed by GitHub
commit a1db1bc5d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
NewHorizons/Utility/SearchUtilities.cs
View File

@ -95,38 +95,41 @@ namespace NewHorizons.Utility
{ {
if (CachedGameObjects.TryGetValue(path, out var go)) return go; if (CachedGameObjects.TryGetValue(path, out var go)) return go;
// 1: normal find
go = GameObject.Find(path); go = GameObject.Find(path);
if (go == null) if (go)
{ {
// find inactive use root + transform.find CachedGameObjects.Add(path, go);
var names = path.Split('/'); return go;
var rootName = names[0];
var root = SceneManager.GetActiveScene().GetRootGameObjects().FirstOrDefault(x => x.name == rootName);
if (root == null)
{
if (warn) Logger.LogWarning($"Couldn't find root object in path {path}");
return null;
}
var childPath = string.Join("/", names.Skip(1));
go = root.FindChild(childPath);
if (go == null)
{
var name = names.Last();
if (warn) Logger.LogWarning($"Couldn't find object in path {path}, will look for potential matches for name {name}");
// find resource to include inactive objects
// also includes prefabs but hopefully thats okay
go = FindResourceOfTypeAndName<GameObject>(name);
if (go == null)
{
if (warn) Logger.LogWarning($"Couldn't find object with name {name}");
return null;
}
}
} }
CachedGameObjects.Add(path, go); // 2: find inactive using root + transform.find
return go; var names = path.Split('/');
var rootName = names[0];
var root = SceneManager.GetActiveScene().GetRootGameObjects().FirstOrDefault(x => x.name == rootName);
var childPath = string.Join("/", names.Skip(1));
go = root ? root.FindChild(childPath) : null;
if (go)
{
CachedGameObjects.Add(path, go);
return go;
}
var name = names.Last();
if (warn) Logger.LogWarning($"Couldn't find object in path {path}, will look for potential matches for name {name}");
// 3: find resource to include inactive objects
// also includes prefabs but hopefully thats okay
go = FindResourceOfTypeAndName<GameObject>(name);
if (go)
{
CachedGameObjects.Add(path, go);
return go;
}
if (warn) Logger.LogWarning($"Couldn't find object with name {name}");
return null;
} }
public static List<GameObject> GetAllChildren(this GameObject parent) public static List<GameObject> GetAllChildren(this GameObject parent)