Gittes-archive/new-horizons
2
0
Fork 0
mirror of https://github.com/Outer-Wilds-New-Horizons/new-horizons.git synced 2025-12-11 20:15:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

move findchild calls after null check to Do Less Work

Browse Source
This commit is contained in:
JohnCorby 2022-07-01 12:53:44 -07:00
parent f7b5bd8606
commit 9cb1fc785f
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
NewHorizons/Builder/Props/BrambleNodeBuilder.cs
View File

@ -151,17 +151,18 @@ namespace NewHorizons.Builder.Props
public static void SetNodeColors(GameObject brambleNode, Color fogTint, Color lightTint) public static void SetNodeColors(GameObject brambleNode, Color fogTint, Color lightTint)
{ {
var fogRenderer = brambleNode.GetComponent<InnerFogWarpVolume>();
var lightShafts = brambleNode.FindChild("Effects/DB_BrambleLightShafts");
if (fogTint != null) if (fogTint != null)
{ {
var fogRenderer = brambleNode.GetComponent<InnerFogWarpVolume>();
fogRenderer._fogColor = fogTint; fogRenderer._fogColor = fogTint;
fogRenderer._useFarFogColor = false; fogRenderer._useFarFogColor = false;
} }
if (lightTint != null) if (lightTint != null)
{ {
var lightShafts = brambleNode.FindChild("Effects/DB_BrambleLightShafts");
var lightShaft1 = lightShafts.FindChild("BrambleLightShaft1"); var lightShaft1 = lightShafts.FindChild("BrambleLightShaft1");
var mat = lightShaft1.GetComponent<MeshRenderer>().material; var mat = lightShaft1.GetComponent<MeshRenderer>().material;
mat.color = lightTint; mat.color = lightTint;
@ -176,11 +177,10 @@ namespace NewHorizons.Builder.Props
public static void SetSeedColors(GameObject brambleSeed, Color fogTint, Color lightTint) public static void SetSeedColors(GameObject brambleSeed, Color fogTint, Color lightTint)
{ {
var fogRenderer = brambleSeed.FindChild("VolumetricFogSphere (2)");
var lightShafts = brambleSeed.FindChild("Terrain_DB_BrambleSphere_Seed_V2 (2)/DB_SeedLightShafts");
if (fogTint != null) if (fogTint != null)
{ {
var fogRenderer = brambleSeed.FindChild("VolumetricFogSphere (2)");
var fogMeshRenderer = fogRenderer.GetComponent<MeshRenderer>(); var fogMeshRenderer = fogRenderer.GetComponent<MeshRenderer>();
var mat = fogMeshRenderer.material; var mat = fogMeshRenderer.material;
mat.color = fogTint; mat.color = fogTint;
@ -189,6 +189,8 @@ namespace NewHorizons.Builder.Props
if (lightTint != null) if (lightTint != null)
{ {
var lightShafts = brambleSeed.FindChild("Terrain_DB_BrambleSphere_Seed_V2 (2)/DB_SeedLightShafts");
var lightShaft1 = lightShafts.FindChild("DB_SeedLightShafts1"); var lightShaft1 = lightShafts.FindChild("DB_SeedLightShafts1");
var mat = lightShaft1.GetComponent<MeshRenderer>().material; var mat = lightShaft1.GetComponent<MeshRenderer>().material;
mat.color = lightTint; mat.color = lightTint;