From 964a4b2d60094b549259945031a385a296f637b1 Mon Sep 17 00:00:00 2001 From: xen-42 Date: Sat, 15 Feb 2025 02:11:20 -0500 Subject: [PATCH] Comment explaining #831 --- NewHorizons/Builder/Props/DetailBuilder.cs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NewHorizons/Builder/Props/DetailBuilder.cs b/NewHorizons/Builder/Props/DetailBuilder.cs index 2de1ccbd..87056fe1 100644 --- a/NewHorizons/Builder/Props/DetailBuilder.cs +++ b/NewHorizons/Builder/Props/DetailBuilder.cs @@ -155,6 +155,17 @@ namespace NewHorizons.Builder.Props continue; } + /* We used to set SectorCullGroup._controllingProxy to null. Now we do not. + * This may break things on copied details because it prevents SetSector from doing anything, + * so that part of the detail might be culled by wrong sector. + * So if you copy something from e.g. Giants Deep it might turn off the detail if you arent in + * the sector of the thing you copied from (since it's still pointing to the original proxy, + * which has the original sector at giants deep there) + * + * Anyway nobody has complained about this for the year it's been like that so closing issue #831 until + * this affects somebody + */ + FixSectoredComponent(component, sector, existingSectors); }