From 7a400e2046fb7b05e8db1ae2e9cf85cd586e4f54 Mon Sep 17 00:00:00 2001 From: Nick Date: Sun, 16 Jul 2023 11:48:37 -0400 Subject: [PATCH] throw error better when planet null --- NewHorizons/Handlers/PlanetCreationHandler.cs | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/NewHorizons/Handlers/PlanetCreationHandler.cs b/NewHorizons/Handlers/PlanetCreationHandler.cs index 8a9129cf..98d55efa 100644 --- a/NewHorizons/Handlers/PlanetCreationHandler.cs +++ b/NewHorizons/Handlers/PlanetCreationHandler.cs @@ -245,20 +245,10 @@ namespace NewHorizons.Handlers try { NHLogger.Log($"Creating [{body.Config.name}]"); - var planetObject = GenerateBody(body, defaultPrimaryToSun); - try - { - planetObject?.SetActive(true); - } - catch (Exception e) - { - NHLogger.LogError($"Error when activating new planet [{body.Config.name}] - {e}"); - } - if (planetObject == null) - { - body.UnloadCache(); - return false; - } + var planetObject = GenerateBody(body, defaultPrimaryToSun) + ?? throw new NullReferenceException("Something went wrong when generating the body but no errors were logged."); + + planetObject.SetActive(true); var ao = planetObject.GetComponent();