From 3c691d351159bae3e414e0a243aa7670c8a3a8d2 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Sat, 18 Mar 2023 23:05:44 -0700 Subject: [PATCH] Revert "(TODO: TEST MORE) use GeneralPropBuilder for normal" This reverts commit 75b703716106773edd4776d111f9fabc9d97c721. --- .../Builder/Props/TranslatorText/TranslatorTextBuilder.cs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/NewHorizons/Builder/Props/TranslatorText/TranslatorTextBuilder.cs b/NewHorizons/Builder/Props/TranslatorText/TranslatorTextBuilder.cs index ef1861fb..9361fd22 100644 --- a/NewHorizons/Builder/Props/TranslatorText/TranslatorTextBuilder.cs +++ b/NewHorizons/Builder/Props/TranslatorText/TranslatorTextBuilder.cs @@ -131,10 +131,9 @@ namespace NewHorizons.Builder.Props case PropModule.NomaiTextInfo.NomaiTextType.Wall: { var nomaiWallTextObj = MakeWallText(planetGO, sector, info, xmlPath, nhBody).gameObject; - // TODO: hawkbar says normal doesnt work, but it seems to be fine in examples. further testing required probably (im lazy) - nomaiWallTextObj = GeneralPropBuilder.MakeFromExisting(nomaiWallTextObj, planetGO, sector, info, normal: info.normal); + nomaiWallTextObj = GeneralPropBuilder.MakeFromExisting(nomaiWallTextObj, planetGO, sector, info); - /* + // using GeneralPropBuilder normal here does not work so have to do it manually if (info.normal != null) { // In global coordinates (normal was in local coordinates) @@ -154,7 +153,6 @@ namespace NewHorizons.Builder.Props nomaiWallTextObj.transform.RotateAround(nomaiWallTextObj.transform.position, forward, zRotation); } } - */ // nomaiWallTextObj.GetComponent().DrawBoundsWithDebugSpheres();