From 8c4f22eab3476d3710c7add1138046c5fa97391f Mon Sep 17 00:00:00 2001 From: xen-42 Date: Fri, 18 Apr 2025 23:35:53 -0400 Subject: [PATCH 1/2] Why did we stop using this --- .github/workflows/build.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 49c55427..c56ab4f4 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -62,7 +62,8 @@ jobs: name: NewHorizons-Schemas-${{ inputs.build_type }} path: .\NewHorizons\Schemas - - name: Check Changed Schemas + - name: Verify Changed Schemas + uses: tj-actions/verify-changed-files@v20 id: changed_files - run: | - echo "files_changed=$(git diff --exit-code NewHorizons/Schemas 2>&1>$null && echo false || echo true)" >> $Env:GITHUB_OUTPUT \ No newline at end of file + with: + files: NewHorizons/Schemas/** \ No newline at end of file From dd90af13148adac5d639a6903604058d54c6ccfb Mon Sep 17 00:00:00 2001 From: Ben C Date: Sat, 19 Apr 2025 03:39:03 +0000 Subject: [PATCH 2/2] Updated Schemas --- .../Schemas/addon_manifest_schema.json | 23 +++++++++++++++++ NewHorizons/Schemas/body_schema.json | 25 ++++++++++++++++++- 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/NewHorizons/Schemas/addon_manifest_schema.json b/NewHorizons/Schemas/addon_manifest_schema.json index d68f545c..401db544 100644 --- a/NewHorizons/Schemas/addon_manifest_schema.json +++ b/NewHorizons/Schemas/addon_manifest_schema.json @@ -103,6 +103,27 @@ "type": "string", "description": "Condition that must be true for this game over to trigger. If this is on a LoadCreditsVolume, leave empty to always trigger this game over.\nNote this is a regular dialogue condition, not a persistent condition." }, + "audio": { + "type": "string", + "description": "The audio to use for the credits music. Can be a path to a .wav/.ogg/.mp3 file, or taken from the AudioClip list.\nCredits will be silent unless this attribute is specified.\nNote: only applies when creditsType is set to \"custom\"." + }, + "audioVolume": { + "type": "number", + "description": "The length of the fade in and out for the credits music.\nNote: only applies when creditsType is set to \"custom\".", + "format": "float", + "default": 1.0 + }, + "audioLooping": { + "type": "boolean", + "description": "Determines if the credits music should loop.\nNote: only applies when creditsType is set to \"custom\".", + "default": false + }, + "length": { + "type": "number", + "description": "Duration of the credits scroll in seconds.\nNote: only applies when creditsType is set to \"custom\".", + "format": "float", + "default": 120.0 + }, "creditsType": { "description": "The type of credits that will run after the game over message is shown", "default": "fast", @@ -152,12 +173,14 @@ "Fast", "Final", "Kazoo", + "Custom", "None" ], "enum": [ "fast", "final", "kazoo", + "custom", "none" ] } diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index c3f289b1..421029c5 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -2964,7 +2964,7 @@ "$ref": "#/definitions/SlideReelType" }, "reelCondition": { - "description": "Exclusive to the slide reel type. Condition/material of the reel. Antique is the Stranger, Pristine is the Dreamworld, Rusted is a burned reel.", + "description": "Exclusive to the slide reel and standing vision torch type. Condition/material of the reel. Antique is the Stranger, Pristine is the Dreamworld, Rusted (exclusive to slide reels) is a burned reel.", "default": "antique", "$ref": "#/definitions/SlideReelCondition" }, @@ -6529,6 +6529,27 @@ "type": "string", "description": "Condition that must be true for this game over to trigger. If this is on a LoadCreditsVolume, leave empty to always trigger this game over.\nNote this is a regular dialogue condition, not a persistent condition." }, + "audio": { + "type": "string", + "description": "The audio to use for the credits music. Can be a path to a .wav/.ogg/.mp3 file, or taken from the AudioClip list.\nCredits will be silent unless this attribute is specified.\nNote: only applies when creditsType is set to \"custom\"." + }, + "audioVolume": { + "type": "number", + "description": "The length of the fade in and out for the credits music.\nNote: only applies when creditsType is set to \"custom\".", + "format": "float", + "default": 1.0 + }, + "audioLooping": { + "type": "boolean", + "description": "Determines if the credits music should loop.\nNote: only applies when creditsType is set to \"custom\".", + "default": false + }, + "length": { + "type": "number", + "description": "Duration of the credits scroll in seconds.\nNote: only applies when creditsType is set to \"custom\".", + "format": "float", + "default": 120.0 + }, "creditsType": { "description": "The type of credits that will run after the game over message is shown", "default": "fast", @@ -6543,12 +6564,14 @@ "Fast", "Final", "Kazoo", + "Custom", "None" ], "enum": [ "fast", "final", "kazoo", + "custom", "none" ] },