From 37cad651f074e65eb90e6847447258df47220396 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Mon, 17 Jun 2024 16:32:54 -0700 Subject: [PATCH] dont reinsert into image cache. we want it to error there --- NewHorizons/Builder/Props/ProjectionBuilder.cs | 3 --- NewHorizons/Utility/Files/ImageUtilities.cs | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/NewHorizons/Builder/Props/ProjectionBuilder.cs b/NewHorizons/Builder/Props/ProjectionBuilder.cs index 2562768c..9f639774 100644 --- a/NewHorizons/Builder/Props/ProjectionBuilder.cs +++ b/NewHorizons/Builder/Props/ProjectionBuilder.cs @@ -542,13 +542,10 @@ namespace NewHorizons.Builder.Props if (cacheExists) { - // This code will execute in order to create the cache - // Loaders go sequentually - Load the inverted textures to the cache so that ImageUtilities will reuse them later if (useInvertedCache) { invertedImageLoader.Start(true); } - // Atlas texture next so that the normal iamgeLoader knows not to regenerate them unless they were missing if (useAtlasCache) { atlasImageLoader.Start(false); diff --git a/NewHorizons/Utility/Files/ImageUtilities.cs b/NewHorizons/Utility/Files/ImageUtilities.cs index 218f64ed..939bcde2 100644 --- a/NewHorizons/Utility/Files/ImageUtilities.cs +++ b/NewHorizons/Utility/Files/ImageUtilities.cs @@ -13,7 +13,7 @@ namespace NewHorizons.Utility.Files // key is path + applied effects private static readonly Dictionary _textureCache = new(); public static bool CheckCachedTexture(string key, out Texture existingTexture) => _textureCache.TryGetValue(key, out existingTexture); - public static void TrackCachedTexture(string key, Texture texture) => _textureCache[key] = texture; + public static void TrackCachedTexture(string key, Texture texture) => _textureCache.Add(key, texture); // dont reinsert cuz that causes memory leak! public static string GetKey(string path) => path.Substring(Main.Instance.ModHelper.OwmlConfig.ModsPath.Length + 1).Replace('\\', '/');