Gittes-archive/new-horizons
2
0
Fork 0
mirror of https://github.com/Outer-Wilds-New-Horizons/new-horizons.git synced 2025-12-11 20:15:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove outside foreach

Browse Source
This commit is contained in:
TerrificTrifid 2022-12-12 20:11:26 -06:00
parent 0fbe807589
commit 32923cea52
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
NewHorizons/Builder/Body/BrambleDimensionBuilder.cs
View File

@ -253,6 +253,7 @@ namespace NewHorizons.Builder.Body
cullController.SetSector(sector); cullController.SetSector(sector);
// Prevent recursion from causing hard crash // Prevent recursion from causing hard crash
List<InnerFogWarpVolume> removeList = new List<InnerFogWarpVolume>();
foreach (var senderWarp in outerFogWarpVolume._senderWarps) foreach (var senderWarp in outerFogWarpVolume._senderWarps)
{ {
var currentWarp = senderWarp; var currentWarp = senderWarp;
@ -260,10 +261,15 @@ namespace NewHorizons.Builder.Body
{ {
if (currentWarp.GetContainerWarpVolume() == outerFogWarpVolume && currentWarp != senderWarp) // game already fixes here to here recursion if (currentWarp.GetContainerWarpVolume() == outerFogWarpVolume && currentWarp != senderWarp) // game already fixes here to here recursion
{ {
outerFogWarpVolume._senderWarps.Remove(senderWarp); break; removeList.Add(senderWarp); break;
} }
else currentWarp = (InnerFogWarpVolume)currentWarp.GetContainerWarpVolume().GetLinkedFogWarpVolume(); else currentWarp = (InnerFogWarpVolume)currentWarp.GetContainerWarpVolume().GetLinkedFogWarpVolume();
} }
}
foreach (var recursiveWarp in removeList)
{
outerFogWarpVolume._senderWarps.Remove(recursiveWarp);
} }
}); });