From 29bf73affb8aea5b494422737a71246e6c98cd02 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Sat, 31 Dec 2022 14:49:31 -0800 Subject: [PATCH] optimize slightly --- NewHorizons/Handlers/PlanetCreationHandler.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/NewHorizons/Handlers/PlanetCreationHandler.cs b/NewHorizons/Handlers/PlanetCreationHandler.cs index 93a37f56..c8191b91 100644 --- a/NewHorizons/Handlers/PlanetCreationHandler.cs +++ b/NewHorizons/Handlers/PlanetCreationHandler.cs @@ -793,9 +793,9 @@ namespace NewHorizons.Handlers public static void SetPositionFromVector(GameObject go, Vector3 position) { - if (go.GetAttachedOWRigidbody() != null) + var rb = go.GetAttachedOWRigidbody(); + if (rb) { - var rb = go.GetAttachedOWRigidbody(); var allChildren = CenterOfTheUniverse.s_rigidbodies.Where(x => x.GetOrigParentBody() == rb).ToArray(); var localPositions = allChildren.Select(x => rb.transform.InverseTransformPoint(x.transform.position)).ToArray(); @@ -803,11 +803,10 @@ namespace NewHorizons.Handlers go.transform.parent = Locator.GetRootTransform(); go.transform.position = position; - for (var i = 0; i < allChildren.Count(); i++) + for (var i = 0; i < allChildren.Length; i++) { - if (allChildren[i].GetComponent() != null) + if (allChildren[i].TryGetComponent(out var orb)) { - var orb = allChildren[i].GetComponent(); orb.SetOrbPosition(go.transform.TransformPoint(localPositions[i])); } else