From 2ce361e182213fd3286c9ecbbd3ba894ebc941c0 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 13:31:41 -0700 Subject: [PATCH 01/11] priority doc --- NewHorizons/External/Modules/BaseModule.cs | 2 +- .../External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NewHorizons/External/Modules/BaseModule.cs b/NewHorizons/External/Modules/BaseModule.cs index 2f36f5a4..cfab241e 100644 --- a/NewHorizons/External/Modules/BaseModule.cs +++ b/NewHorizons/External/Modules/BaseModule.cs @@ -69,7 +69,7 @@ namespace NewHorizons.External.Modules /// /// Optional. You can force this planet's gravity to be felt over other gravity/zero-gravity sources by increasing this number. /// - public int gravityVolumePriority; + [DefaultValue(0)] public int gravityVolumePriority = 0; #region Obsolete diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 574d93dc..408bca69 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -14,6 +14,8 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// /// The priority for this volume's effects to be applied. /// Ex, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity. + /// + /// Default value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. /// [DefaultValue(1)] public int priority = 1; } From 7b23580e56668365609d75a32da1468f504c17c5 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 13:45:09 -0700 Subject: [PATCH 02/11] doc layers --- .../Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 408bca69..ce35c031 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -8,12 +8,19 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos { /// /// The layer of this volume. + /// + /// Layers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal. + /// The exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer. + /// + /// Default value here is 0 because in most cases people don't want to think about layers and only care about priority. /// [DefaultValue(0)] public int layer = 0; /// - /// The priority for this volume's effects to be applied. - /// Ex, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity. + /// The priority of this volume. + /// + /// Volumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal. + /// Ex: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity. /// /// Default value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. /// From 44d3a24d3aac7e6e030d75437ef4c2b3133f980a Mon Sep 17 00:00:00 2001 From: Ben C Date: Fri, 26 May 2023 20:47:09 +0000 Subject: [PATCH 03/11] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index ce24bb0f..037d202f 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -560,7 +560,8 @@ "gravityVolumePriority": { "type": "integer", "description": "Optional. You can force this planet's gravity to be felt over other gravity/zero-gravity sources by increasing this number.", - "format": "int32" + "format": "int32", + "default": 0 } } }, @@ -3382,13 +3383,13 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, "priority": { "type": "integer", - "description": "The priority for this volume's effects to be applied. \nEx, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.", + "description": "The priority of this volume.\n\nVolumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal.\nEx: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.\n \nDefault value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. ", "format": "int32", "default": 1 }, @@ -3560,13 +3561,13 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, "priority": { "type": "integer", - "description": "The priority for this volume's effects to be applied. \nEx, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.", + "description": "The priority of this volume.\n\nVolumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal.\nEx: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.\n \nDefault value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. ", "format": "int32", "default": 1 }, @@ -4185,13 +4186,13 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, "priority": { "type": "integer", - "description": "The priority for this volume's effects to be applied. \nEx, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.", + "description": "The priority of this volume.\n\nVolumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal.\nEx: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.\n \nDefault value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. ", "format": "int32", "default": 1 }, @@ -4239,13 +4240,13 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, "priority": { "type": "integer", - "description": "The priority for this volume's effects to be applied. \nEx, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.", + "description": "The priority of this volume.\n\nVolumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal.\nEx: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.\n \nDefault value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. ", "format": "int32", "default": 1 }, @@ -4313,13 +4314,13 @@ }, "layer": { "type": "integer", - "description": "The layer of this volume.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, "priority": { "type": "integer", - "description": "The priority for this volume's effects to be applied. \nEx, a player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.", + "description": "The priority of this volume.\n\nVolumes of higher priority will override volumes of lower priority. Volumes of the same priority will stack like normal.\nEx: A player in a gravity volume with priority 0, and zero-gravity volume with priority 1, will feel zero gravity.\n \nDefault value here is 1 instead of 0 so it automatically overrides planet gravity, which is 0 by default. ", "format": "int32", "default": 1 } From c696129f5661acad9cda95301f16496817b6e90f Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 14:27:19 -0700 Subject: [PATCH 04/11] clarify --- .../External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index ce35c031..4e42cff7 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -10,7 +10,7 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// The layer of this volume. /// /// Layers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal. - /// The exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer. + /// The exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. /// /// Default value here is 0 because in most cases people don't want to think about layers and only care about priority. /// From 08ac2e1256a6a06bc0acbaff57121a94d8dcb7bf Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 14:29:25 -0700 Subject: [PATCH 05/11] clarify AGAIN --- .../External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 4e42cff7..16349c70 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -10,7 +10,7 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// The layer of this volume. /// /// Layers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal. - /// The exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. + /// The exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal. /// /// Default value here is 0 because in most cases people don't want to think about layers and only care about priority. /// From 1c68a9711df1ff4e72ec5686bf45832a341f07f1 Mon Sep 17 00:00:00 2001 From: Ben C Date: Fri, 26 May 2023 21:31:44 +0000 Subject: [PATCH 06/11] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index 037d202f..2ae32650 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -3383,7 +3383,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, @@ -3561,7 +3561,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, @@ -4186,7 +4186,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, @@ -4240,7 +4240,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, @@ -4314,7 +4314,7 @@ }, "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. The priority of volumes in layer 0 will override volumes in all other layers, as if they were all in the same layer.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", "format": "int32", "default": 0 }, From b29cbb9a955f174c3e78d56963d47751e04d16de Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 14:37:21 -0700 Subject: [PATCH 07/11] remove default cuz its not true --- .../Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 16349c70..8a7dd099 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -10,9 +10,7 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// The layer of this volume. /// /// Layers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal. - /// The exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal. - /// - /// Default value here is 0 because in most cases people don't want to think about layers and only care about priority. + /// The exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal. /// [DefaultValue(0)] public int layer = 0; From 3943a0f02a7ab35f5db77b12607f2b95d6d9e401 Mon Sep 17 00:00:00 2001 From: Ben C Date: Fri, 26 May 2023 21:43:07 +0000 Subject: [PATCH 08/11] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index 2ae32650..4be8d471 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -3383,7 +3383,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", "format": "int32", "default": 0 }, @@ -3561,7 +3561,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", "format": "int32", "default": 0 }, @@ -4186,7 +4186,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", "format": "int32", "default": 0 }, @@ -4240,7 +4240,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", "format": "int32", "default": 0 }, @@ -4314,7 +4314,7 @@ }, "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. Layer 0 effectively bypasses the layer system. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nDefault value here is 0 because in most cases people don't want to think about layers and only care about priority.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", "format": "int32", "default": 0 }, From da309ac8492fbfa570bb193b1a82da8620f97b97 Mon Sep 17 00:00:00 2001 From: Nick Date: Fri, 26 May 2023 18:40:24 -0400 Subject: [PATCH 09/11] Update PriorityVolumeInfo.cs --- .../Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 8a7dd099..0002f23a 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -11,6 +11,12 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// /// Layers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal. /// The exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal. + /// + /// Ex: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers. + /// If there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the + /// gravity of the planet (priority 2 is greater than 1). + /// + /// Default value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer. /// [DefaultValue(0)] public int layer = 0; From a7557ac22d07dcdfd0305303ea075db1156b09d6 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Fri, 26 May 2023 15:42:29 -0700 Subject: [PATCH 10/11] bleh --- .../External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs index 0002f23a..14e99020 100644 --- a/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs +++ b/NewHorizons/External/Modules/Volumes/VolumeInfos/PriorityVolumeInfo.cs @@ -14,7 +14,7 @@ namespace NewHorizons.External.Modules.Volumes.VolumeInfos /// /// Ex: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers. /// If there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the - /// gravity of the planet (priority 2 is greater than 1). + /// gravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer. /// /// Default value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer. /// From 41f5a774618e1c843dbf31cc73b3aeb7b84743ec Mon Sep 17 00:00:00 2001 From: Ben C Date: Fri, 26 May 2023 22:46:47 +0000 Subject: [PATCH 11/11] Updated Schemas --- NewHorizons/Schemas/body_schema.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/NewHorizons/Schemas/body_schema.json b/NewHorizons/Schemas/body_schema.json index 4be8d471..cbcb608a 100644 --- a/NewHorizons/Schemas/body_schema.json +++ b/NewHorizons/Schemas/body_schema.json @@ -3383,7 +3383,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nEx: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers.\nIf there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the \ngravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer.\n \nDefault value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer.", "format": "int32", "default": 0 }, @@ -3561,7 +3561,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nEx: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers.\nIf there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the \ngravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer.\n \nDefault value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer.", "format": "int32", "default": 0 }, @@ -4186,7 +4186,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nEx: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers.\nIf there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the \ngravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer.\n \nDefault value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer.", "format": "int32", "default": 0 }, @@ -4240,7 +4240,7 @@ "properties": { "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nEx: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers.\nIf there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the \ngravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer.\n \nDefault value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer.", "format": "int32", "default": 0 }, @@ -4314,7 +4314,7 @@ }, "layer": { "type": "integer", - "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.", + "description": "The layer of this volume.\n\nLayers separate the priority system. The priority of volumes in one layer will not affect or override volumes in another. The highest priority volume in each layer will stack like normal.\nThe exception is layer 0. A higher-priority volume in layer 0 will override lower-priority volumes in ALL other layers. A lower-priority volume in layer 0 will stack with other layers like normal.\n \nEx: A player could be affected by the sun on layer 9 priority 0 and planet gravity on layer 3 priority 2. They would experience the gravity of both volumes since they are on different layers.\nIf there was a zero-g volume on layer 0 priority 1, since it is on layer 0 it will override the gravity from the sun (priority 0 which is less than 1) but they will still feel the \ngravity of the planet (priority 2 is greater than 1). The zero-g volume will also still be applied because it is on a different layer.\n \nDefault value here is 0 which means this volume's priority will be evaluated against all other priority volumes regardless of their layer.", "format": "int32", "default": 0 },