From 64f81f9dcaec0024924d4d700f09fcf85d6ce0d9 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Sun, 22 May 2022 16:25:53 -0700 Subject: [PATCH 1/3] make color good --- .../Builder/Atmosphere/AtmosphereBuilder.cs | 2 +- .../Builder/Atmosphere/CloudsBuilder.cs | 6 +++--- NewHorizons/Builder/Atmosphere/FogBuilder.cs | 4 ++-- .../Builder/Atmosphere/VolumesBuilder.cs | 2 +- NewHorizons/Builder/Body/FunnelBuilder.cs | 4 ++-- NewHorizons/Builder/Body/LavaBuilder.cs | 4 ++-- NewHorizons/Builder/Body/ProcGenBuilder.cs | 2 +- NewHorizons/Builder/Body/ProxyBuilder.cs | 6 +++--- NewHorizons/Builder/Body/SandBuilder.cs | 4 ++-- NewHorizons/Builder/Body/StarBuilder.cs | 18 +++++++++--------- NewHorizons/Builder/Body/WaterBuilder.cs | 6 +++--- .../Builder/Orbital/OrbitlineBuilder.cs | 8 ++++---- NewHorizons/Builder/Props/ProjectionBuilder.cs | 2 +- NewHorizons/Builder/Props/TornadoBuilder.cs | 4 ++-- NewHorizons/Builder/Props/VolcanoBuilder.cs | 4 ++-- NewHorizons/Builder/ShipLog/MapModeBuilder.cs | 10 +++++----- .../Builder/ShipLog/RumorModeBuilder.cs | 4 ++-- .../SizeControllers/StarEvolutionController.cs | 4 ++-- NewHorizons/Utility/MColor.cs | 4 +--- 19 files changed, 48 insertions(+), 50 deletions(-) diff --git a/NewHorizons/Builder/Atmosphere/AtmosphereBuilder.cs b/NewHorizons/Builder/Atmosphere/AtmosphereBuilder.cs index c60ae6a3..67de6b32 100644 --- a/NewHorizons/Builder/Atmosphere/AtmosphereBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/AtmosphereBuilder.cs @@ -24,7 +24,7 @@ namespace NewHorizons.Builder.Atmosphere meshRenderer.material.SetFloat(InnerRadius, atmosphereModule.clouds != null ? atmosphereModule.size : surfaceSize); meshRenderer.material.SetFloat(OuterRadius, atmosphereModule.size * 1.2f); if (atmosphereModule.atmosphereTint != null) - meshRenderer.material.SetColor(SkyColor, atmosphereModule.atmosphereTint.ToColor()); + meshRenderer.material.SetColor(SkyColor, atmosphereModule.atmosphereTint); } atmo.SetActive(true); diff --git a/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs b/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs index ea20d434..6b2bff82 100644 --- a/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/CloudsBuilder.cs @@ -39,7 +39,7 @@ namespace NewHorizons.Builder.Atmosphere // If they set a colour apply it to all the materials else keep the default QM one if (atmo.clouds.tint != null) { - var bottomColor = atmo.clouds.tint.ToColor(); + var bottomColor = atmo.clouds.tint; var bottomTSRTempArray = new Material[2]; @@ -119,7 +119,7 @@ namespace NewHorizons.Builder.Atmosphere for(int i = 0; i < atmo.clouds.lightningGradient.Length; i++) { var pair = atmo.clouds.lightningGradient[i]; - gradient[i] = new GradientColorKey(pair.Tint.ToColor(), pair.Time); + gradient[i] = new GradientColorKey(pair.Tint, pair.Time); } lightningGenerator._lightColor.colorKeys = gradient; @@ -138,7 +138,7 @@ namespace NewHorizons.Builder.Atmosphere public static GameObject MakeTopClouds(GameObject rootObject, AtmosphereModule atmo, IModBehaviour mod) { - Color cloudTint = atmo.clouds.tint?.ToColor() ?? Color.white; + Color cloudTint = atmo.clouds.tint ?? Color.white; Texture2D image, cap, ramp; diff --git a/NewHorizons/Builder/Atmosphere/FogBuilder.cs b/NewHorizons/Builder/Atmosphere/FogBuilder.cs index 2ee92b02..be8f9345 100644 --- a/NewHorizons/Builder/Atmosphere/FogBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/FogBuilder.cs @@ -30,7 +30,7 @@ namespace NewHorizons.Builder.Atmosphere PFC.fogExponent = 1f; PFC.fogColorRampTexture = dbPlanetaryFogController.fogColorRampTexture; PFC.fogColorRampIntensity = 1f; - PFC.fogTint = atmo.fogTint.ToColor(); + PFC.fogTint = atmo.fogTint; GameObject lodFogGO = new GameObject("LODFogSphere"); lodFogGO.SetActive(false); @@ -42,7 +42,7 @@ namespace NewHorizons.Builder.Atmosphere MeshRenderer lodMR = lodFogGO.AddComponent(); lodMR.material = new Material(brambleLODFog.GetComponent().material); - lodMR.material.color = atmo.fogTint.ToColor(); + lodMR.material.color = atmo.fogTint; lodMR.material.renderQueue = 1000; /* diff --git a/NewHorizons/Builder/Atmosphere/VolumesBuilder.cs b/NewHorizons/Builder/Atmosphere/VolumesBuilder.cs index 6a960870..e5dfc508 100644 --- a/NewHorizons/Builder/Atmosphere/VolumesBuilder.cs +++ b/NewHorizons/Builder/Atmosphere/VolumesBuilder.cs @@ -44,7 +44,7 @@ namespace NewHorizons.Builder.Atmosphere var cloudMaterial = new Material(gdRuleset._cloudMaterial); if (config.Atmosphere?.clouds?.tint != null) { - cloudMaterial.SetColor(FogColor, config.Atmosphere.clouds.tint.ToColor32()); + cloudMaterial.SetColor(FogColor, config.Atmosphere.clouds.tint); } ER._cloudMaterial = cloudMaterial; diff --git a/NewHorizons/Builder/Body/FunnelBuilder.cs b/NewHorizons/Builder/Body/FunnelBuilder.cs index 5f9ccd93..3f6b22ec 100644 --- a/NewHorizons/Builder/Body/FunnelBuilder.cs +++ b/NewHorizons/Builder/Body/FunnelBuilder.cs @@ -70,7 +70,7 @@ namespace NewHorizons.Builder.Body materials[i] = new Material(waterMaterials[i]); if (module.tint != null) { - materials[i].SetColor(FogColor, module.tint.ToColor()); + materials[i].SetColor(FogColor, module.tint); } } @@ -117,7 +117,7 @@ namespace NewHorizons.Builder.Body if (module.tint != null) { - lavaMaterial.SetColor(EmissionColor, module.tint.ToColor()); + lavaMaterial.SetColor(EmissionColor, module.tint); } proxyGO.GetComponentInChildren().material = lavaMaterial; diff --git a/NewHorizons/Builder/Body/LavaBuilder.cs b/NewHorizons/Builder/Body/LavaBuilder.cs index 9d2f40df..fde7cbe0 100644 --- a/NewHorizons/Builder/Body/LavaBuilder.cs +++ b/NewHorizons/Builder/Body/LavaBuilder.cs @@ -32,7 +32,7 @@ namespace NewHorizons.Builder.Body lavaSphere.transform.localScale = Vector3.one; lavaSphere.transform.name = "LavaSphere"; lavaSphere.GetComponent().material.SetFloat(HeightScale, heightScale); - if (module.tint != null) lavaSphere.GetComponent().material.SetColor(EmissionColor, module.tint.ToColor()); + if (module.tint != null) lavaSphere.GetComponent().material.SetColor(EmissionColor, module.tint); var sectorCullGroup = lavaSphere.GetComponent(); sectorCullGroup.SetSector(sector); @@ -44,7 +44,7 @@ namespace NewHorizons.Builder.Body proxyLavaSphere.transform.localScale = Vector3.one; proxyLavaSphere.name = "LavaSphere_Proxy"; proxyLavaSphere.GetComponent().material.SetFloat(HeightScale, heightScale); - if (module.tint != null) proxyLavaSphere.GetComponent().material.SetColor(EmissionColor, module.tint.ToColor()); + if (module.tint != null) proxyLavaSphere.GetComponent().material.SetColor(EmissionColor, module.tint); var sectorProxy = moltenCoreProxy.GetComponent(); sectorProxy._renderers = new List { proxyLavaSphere.GetComponent() }; diff --git a/NewHorizons/Builder/Body/ProcGenBuilder.cs b/NewHorizons/Builder/Body/ProcGenBuilder.cs index af13da22..af85572d 100644 --- a/NewHorizons/Builder/Body/ProcGenBuilder.cs +++ b/NewHorizons/Builder/Body/ProcGenBuilder.cs @@ -27,7 +27,7 @@ namespace NewHorizons.Builder.Body var cubeSphereMR = icosphere.AddComponent(); cubeSphereMR.material = new Material(Shader.Find("Standard")); - cubeSphereMR.material.color = module.color != null ? module.color.ToColor() : Color.white; + cubeSphereMR.material.color = module.color != null ? module.color : Color.white; var cubeSphereMC = icosphere.AddComponent(); cubeSphereMC.sharedMesh = mesh; diff --git a/NewHorizons/Builder/Body/ProxyBuilder.cs b/NewHorizons/Builder/Body/ProxyBuilder.cs index 33510c62..64f8fcd0 100644 --- a/NewHorizons/Builder/Body/ProxyBuilder.cs +++ b/NewHorizons/Builder/Body/ProxyBuilder.cs @@ -77,18 +77,18 @@ namespace NewHorizons.Builder.Body if (realSize < body.Config.Lava.size) realSize = body.Config.Lava.size; var material = new Material(lavaMaterial); - if (body.Config.Lava.tint != null) material.SetColor(EmissionColor, body.Config.Lava.tint.ToColor()); + if (body.Config.Lava.tint != null) material.SetColor(EmissionColor, body.Config.Lava.tint); sphere.GetComponent().material = material; } if (body.Config.Water != null) { - var colour = body.Config.Water.tint?.ToColor() ?? Color.blue; + var colour = body.Config.Water.tint ?? Color.blue; AddColouredSphere(newProxy, body.Config.Water.size, body.Config.Water.Curve, colour); if (realSize < body.Config.Water.size) realSize = body.Config.Water.size; } if (body.Config.Sand != null) { - var colour = body.Config.Sand.Tint?.ToColor() ?? Color.yellow; + var colour = body.Config.Sand.Tint ?? Color.yellow; AddColouredSphere(newProxy, body.Config.Sand.Size, body.Config.Sand.Curve, colour); if (realSize < body.Config.Sand.Size) realSize = body.Config.Sand.Size; } diff --git a/NewHorizons/Builder/Body/SandBuilder.cs b/NewHorizons/Builder/Body/SandBuilder.cs index 261a3434..a6037315 100644 --- a/NewHorizons/Builder/Body/SandBuilder.cs +++ b/NewHorizons/Builder/Body/SandBuilder.cs @@ -24,8 +24,8 @@ namespace NewHorizons.Builder.Body new Material(sandMaterials[1]) }; GameObject.Destroy(oldMR); - sandMR.sharedMaterials[0].color = module.Tint.ToColor32(); - sandMR.sharedMaterials[1].color = module.Tint.ToColor32(); + sandMR.sharedMaterials[0].color = module.Tint; + sandMR.sharedMaterials[1].color = module.Tint; } var collider = GameObject.Instantiate(GameObject.Find("TowerTwin_Body/SandSphere_Draining/Collider"), sandGO.transform); diff --git a/NewHorizons/Builder/Body/StarBuilder.cs b/NewHorizons/Builder/Body/StarBuilder.cs index 0d93e1ae..07972a93 100644 --- a/NewHorizons/Builder/Body/StarBuilder.cs +++ b/NewHorizons/Builder/Body/StarBuilder.cs @@ -42,13 +42,13 @@ namespace NewHorizons.Builder.Body PlanetaryFogController fog = sunAtmosphere.transform.Find("FogSphere").GetComponent(); if (starModule.tint != null) { - fog.fogTint = starModule.tint.ToColor(); + fog.fogTint = starModule.tint; sunAtmosphere.transform.Find("AtmoSphere").transform.localScale = Vector3.one; foreach (var lod in sunAtmosphere.transform.Find("AtmoSphere").GetComponentsInChildren()) { - lod.material.SetColor(SkyColor, starModule.tint.ToColor()); - lod.material.SetColor(AtmosFar, starModule.tint.ToColor()); - lod.material.SetColor(AtmosNear, starModule.tint.ToColor()); + lod.material.SetColor(SkyColor, starModule.tint); + lod.material.SetColor(AtmosFar, starModule.tint); + lod.material.SetColor(AtmosNear, starModule.tint); lod.material.SetFloat(InnerRadius, starModule.size); lod.material.SetFloat(OuterRadius, starModule.size * OuterRadiusRatio); } @@ -90,7 +90,7 @@ namespace NewHorizons.Builder.Body light.range *= Mathf.Sqrt(starModule.solarLuminosity); Color lightColour = light.color; - if (starModule.lightTint != null) lightColour = starModule.lightTint.ToColor(); + if (starModule.lightTint != null) lightColour = starModule.lightTint; light.color = lightColour; ambientLight.color = lightColour; @@ -177,7 +177,7 @@ namespace NewHorizons.Builder.Body if (starModule.tint != null) { - var flareTint = starModule.tint.ToColor(); + var flareTint = starModule.tint; var emitter = solarFlareEmitter.GetComponent(); emitter.tint = flareTint; foreach (var controller in solarFlareEmitter.GetComponentsInChildren()) @@ -195,7 +195,7 @@ namespace NewHorizons.Builder.Body { TessellatedSphereRenderer surface = sunSurface.GetComponent(); - var colour = starModule.tint.ToColor(); + var colour = starModule.tint; var sun = GameObject.Find("Sun_Body"); var mainSequenceMaterial = sun.GetComponent().GetValue("_startSurfaceMaterial"); @@ -211,7 +211,7 @@ namespace NewHorizons.Builder.Body if (starModule.endTint != null) { - var endColour = starModule.endTint.ToColor(); + var endColour = starModule.endTint; darkenedColor = new Color(endColour.r * mod, endColour.g * mod, endColour.b * mod); } @@ -233,7 +233,7 @@ namespace NewHorizons.Builder.Body if (starModule.supernovaTint != null) { - var colour = starModule.supernovaTint.ToColor(); + var colour = starModule.supernovaTint; var supernovaMaterial = new Material(supernova._supernovaMaterial); var ramp = ImageUtilities.LerpGreyscaleImage(ImageUtilities.GetTexture(Main.Instance, "AssetBundle/Effects_SUN_Supernova_d.png"), Color.white, colour); diff --git a/NewHorizons/Builder/Body/WaterBuilder.cs b/NewHorizons/Builder/Body/WaterBuilder.cs index acca5a7d..bf0aaa12 100644 --- a/NewHorizons/Builder/Body/WaterBuilder.cs +++ b/NewHorizons/Builder/Body/WaterBuilder.cs @@ -40,8 +40,8 @@ namespace NewHorizons.Builder.Body tempArray[i] = new Material(GDSharedMaterials[i]); if (module.tint != null) { - tempArray[i].color = module.tint.ToColor(); - tempArray[i].SetColor("_FogColor", module.tint.ToColor()); + tempArray[i].color = module.tint; + tempArray[i].SetColor("_FogColor", module.tint); } } @@ -85,7 +85,7 @@ namespace NewHorizons.Builder.Body if (module.tint != null) { - var adjustedColour = module.tint.ToColor() / 4f; + var adjustedColour = (Color)module.tint / 4f; adjustedColour.a = adjustedColour.a * 4f; fogGO.GetComponent().material.color = adjustedColour; } diff --git a/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs b/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs index 61a8b61a..0d494251 100644 --- a/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs +++ b/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs @@ -57,13 +57,13 @@ namespace NewHorizons.Builder.Orbital } var color = Color.white; - if (config.Orbit.Tint != null) color = config.Orbit.Tint.ToColor32(); - else if (config.Star != null) color = config.Star.tint.ToColor32(); - else if (config.Atmosphere?.clouds?.tint != null) color = config.Atmosphere.clouds.tint.ToColor32(); + if (config.Orbit.Tint != null) color = config.Orbit.Tint; + else if (config.Star != null) color = config.Star.tint; + else if (config.Atmosphere?.clouds?.tint != null) color = config.Atmosphere.clouds.tint; else if (config.Singularity != null) color = new Color(1f, 0.5f, 1f); else if (config.Water != null) color = new Color(0.5f, 0.5f, 1f); else if (config.Lava != null) color = new Color(1f, 0.5f, 0.5f); - else if (config.Atmosphere != null && config.Atmosphere.fogTint != null) color = config.Atmosphere.fogTint.ToColor32(); + else if (config.Atmosphere != null && config.Atmosphere.fogTint != null) color = config.Atmosphere.fogTint; var fade = isMoon; diff --git a/NewHorizons/Builder/Props/ProjectionBuilder.cs b/NewHorizons/Builder/Props/ProjectionBuilder.cs index 4b111c86..2a5bd451 100644 --- a/NewHorizons/Builder/Props/ProjectionBuilder.cs +++ b/NewHorizons/Builder/Props/ProjectionBuilder.cs @@ -185,7 +185,7 @@ namespace NewHorizons.Builder.Props var ambientLight = new SlideAmbientLightModule(); ambientLight._intensity = slideInfo.ambientLightIntensity; ambientLight._range = slideInfo.ambientLightRange; - ambientLight._color = slideInfo.ambientLightColor.ToColor(); + ambientLight._color = slideInfo.ambientLightColor; ambientLight._spotIntensityMod = slideInfo.spotIntensityMod; modules.Add(ambientLight); } diff --git a/NewHorizons/Builder/Props/TornadoBuilder.cs b/NewHorizons/Builder/Props/TornadoBuilder.cs index b7f0d6ef..9f39864c 100644 --- a/NewHorizons/Builder/Props/TornadoBuilder.cs +++ b/NewHorizons/Builder/Props/TornadoBuilder.cs @@ -148,7 +148,7 @@ namespace NewHorizons.Builder.Props if (info.tint != null) { - ApplyTint(tornadoGO, info.tint.ToColor(), false, downwards); + ApplyTint(tornadoGO, info.tint, false, downwards); } if (info.wanderRate != 0) @@ -205,7 +205,7 @@ namespace NewHorizons.Builder.Props if (info.tint != null) { - ApplyTint(hurricaneGO, info.tint.ToColor(), true, false); + ApplyTint(hurricaneGO, info.tint, true, false); } if (info.wanderRate != 0) diff --git a/NewHorizons/Builder/Props/VolcanoBuilder.cs b/NewHorizons/Builder/Props/VolcanoBuilder.cs index a9e04b51..ef649ddf 100644 --- a/NewHorizons/Builder/Props/VolcanoBuilder.cs +++ b/NewHorizons/Builder/Props/VolcanoBuilder.cs @@ -50,8 +50,8 @@ namespace NewHorizons.Builder.Props meteor.transform.localScale = Vector3.one * info.scale; var mat = meteor.GetComponentInChildren().material; - mat.SetColor(Color1, info.stoneTint?.ToColor() ?? defaultStoneTint); - mat.SetColor(EmissionColor, info.lavaTint?.ToColor() ?? defaultLavaTint); + mat.SetColor(Color1, info.stoneTint ?? defaultStoneTint); + mat.SetColor(EmissionColor, info.lavaTint ?? defaultLavaTint); var detectors = meteor.transform.Find("ConstantDetectors").gameObject; GameObject.Destroy(detectors.GetComponent()); diff --git a/NewHorizons/Builder/ShipLog/MapModeBuilder.cs b/NewHorizons/Builder/ShipLog/MapModeBuilder.cs index 5b13fe77..8950f14a 100644 --- a/NewHorizons/Builder/ShipLog/MapModeBuilder.cs +++ b/NewHorizons/Builder/ShipLog/MapModeBuilder.cs @@ -521,10 +521,10 @@ namespace NewHorizons.Builder.ShipLog } var starColor = body.Config?.Star?.tint; - if (starColor != null) return starColor.ToColor(); + if (starColor != null) return starColor; var atmoColor = body.Config.Atmosphere?.atmosphereTint; - if (body.Config.Atmosphere?.clouds != null && atmoColor != null) return atmoColor.ToColor(); + if (body.Config.Atmosphere?.clouds != null && atmoColor != null) return atmoColor; if (body.Config?.HeightMap?.textureMap != null) { @@ -538,13 +538,13 @@ namespace NewHorizons.Builder.ShipLog } var waterColor = body.Config.Water?.tint; - if (waterColor != null) return waterColor.ToColor(); + if (waterColor != null) return waterColor; var lavaColor = body.Config.Lava?.tint; - if (lavaColor != null) return lavaColor.ToColor(); + if (lavaColor != null) return lavaColor; var sandColor = body.Config.Sand?.Tint; - if (sandColor != null) return sandColor.ToColor(); + if (sandColor != null) return sandColor; } catch (Exception) { diff --git a/NewHorizons/Builder/ShipLog/RumorModeBuilder.cs b/NewHorizons/Builder/ShipLog/RumorModeBuilder.cs index 23c50ea2..f2b14b76 100644 --- a/NewHorizons/Builder/ShipLog/RumorModeBuilder.cs +++ b/NewHorizons/Builder/ShipLog/RumorModeBuilder.cs @@ -31,8 +31,8 @@ namespace NewHorizons.Builder.ShipLog { CuriosityName newName = (CuriosityName)8 + _rawNameToCuriosityName.Count; _rawNameToCuriosityName.Add(newColor.id, newName); - _curiosityColors.Add(newName, newColor.color.ToColor()); - _curiosityHighlightColors.Add(newName, newColor.highlightColor.ToColor()); + _curiosityColors.Add(newName, newColor.color); + _curiosityHighlightColors.Add(newName, newColor.highlightColor); } } } diff --git a/NewHorizons/Components/SizeControllers/StarEvolutionController.cs b/NewHorizons/Components/SizeControllers/StarEvolutionController.cs index 25b18414..84f7b87b 100644 --- a/NewHorizons/Components/SizeControllers/StarEvolutionController.cs +++ b/NewHorizons/Components/SizeControllers/StarEvolutionController.cs @@ -66,7 +66,7 @@ namespace NewHorizons.Components.SizeControllers } else { - _startColour = startColour.ToColor(); + _startColour = startColour; _startSurfaceMaterial.color = _startColour; } @@ -77,7 +77,7 @@ namespace NewHorizons.Components.SizeControllers } else { - _endColour = endColour.ToColor(); + _endColour = endColour; _endSurfaceMaterial.color = _endColour; } diff --git a/NewHorizons/Utility/MColor.cs b/NewHorizons/Utility/MColor.cs index 2212bac0..c4c1ad70 100644 --- a/NewHorizons/Utility/MColor.cs +++ b/NewHorizons/Utility/MColor.cs @@ -37,8 +37,6 @@ namespace NewHorizons.Utility [System.ComponentModel.DataAnnotations.Range(0f, int.MaxValue)] public int a; - public Color32 ToColor32() => new Color32((byte)r, (byte)g, (byte)b, (byte)a); - - public Color ToColor() => new Color(r / 255f, g / 255f, b / 255f, a / 255f); + public static implicit operator Color(MColor c) => new Color(c.r / 255f, c.g / 255f, c.b / 255f, c.a / 255f); } } From 5fad2dc1ee6ef7aceadbf0382a1e50a2ebe3d48d Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Sun, 22 May 2022 16:26:26 -0700 Subject: [PATCH 2/3] make doc xml generate good --- NewHorizons/NewHorizons.csproj | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/NewHorizons/NewHorizons.csproj b/NewHorizons/NewHorizons.csproj index cb332645..9627f0eb 100644 --- a/NewHorizons/NewHorizons.csproj +++ b/NewHorizons/NewHorizons.csproj @@ -8,15 +8,14 @@ Copyright © 2020 true false + true portable - C:\Users\bwc67\AppData\Roaming\OuterWildsModManager\OWML\Mods\xen.NewHorizons\NewHorizons.xml 1701;1702;1591 none - C:\Users\bwc67\AppData\Roaming\OuterWildsModManager\OWML\Mods\xen.NewHorizons\NewHorizons.xml 1701;1702;1591 From 9668f68a63d6a06ca891217e950a2f4de85d9bd2 Mon Sep 17 00:00:00 2001 From: JohnCorby Date: Sun, 22 May 2022 16:29:02 -0700 Subject: [PATCH 3/3] make IOrbitalParameters lowercase --- .../Builder/Body/AsteroidBeltBuilder.cs | 8 ++--- .../Builder/General/AstroObjectBuilder.cs | 4 +-- .../Builder/Orbital/InitialMotionBuilder.cs | 12 +++---- .../Builder/Orbital/OrbitlineBuilder.cs | 14 ++++---- NewHorizons/Builder/ShipLog/MapModeBuilder.cs | 2 +- .../Components/Orbital/IOrbitalParameters.cs | 13 ++++---- .../Components/Orbital/NHAstroObject.cs | 32 +++++++++---------- .../Components/Orbital/OrbitalParameters.cs | 26 +++++++-------- NewHorizons/Components/QuantumPlanet.cs | 4 +-- NewHorizons/External/Modules/OrbitModule.cs | 16 +++++----- NewHorizons/Handlers/PlanetCreationHandler.cs | 4 +-- 11 files changed, 68 insertions(+), 67 deletions(-) diff --git a/NewHorizons/Builder/Body/AsteroidBeltBuilder.cs b/NewHorizons/Builder/Body/AsteroidBeltBuilder.cs index 41f0b47f..7839ba51 100644 --- a/NewHorizons/Builder/Body/AsteroidBeltBuilder.cs +++ b/NewHorizons/Builder/Body/AsteroidBeltBuilder.cs @@ -41,11 +41,11 @@ namespace NewHorizons.Builder.Body config.Orbit = new OrbitModule() { IsMoon = true, - Inclination = belt.inclination + Random.Range(-2f, 2f), - LongitudeOfAscendingNode = belt.longitudeOfAscendingNode, - TrueAnomaly = 360f * (i + Random.Range(-0.2f, 0.2f)) / (float)count, + inclination = belt.inclination + Random.Range(-2f, 2f), + longitudeOfAscendingNode = belt.longitudeOfAscendingNode, + trueAnomaly = 360f * (i + Random.Range(-0.2f, 0.2f)) / (float)count, PrimaryBody = bodyName, - SemiMajorAxis = Random.Range(belt.innerRadius, belt.outerRadius), + semiMajorAxis = Random.Range(belt.innerRadius, belt.outerRadius), ShowOrbitLine = false }; diff --git a/NewHorizons/Builder/General/AstroObjectBuilder.cs b/NewHorizons/Builder/General/AstroObjectBuilder.cs index 77e6e08d..777a75e3 100644 --- a/NewHorizons/Builder/General/AstroObjectBuilder.cs +++ b/NewHorizons/Builder/General/AstroObjectBuilder.cs @@ -28,8 +28,8 @@ namespace NewHorizons.Builder.General if (primaryBody?.gameObject?.GetComponent() != null && !config.Orbit.IsStatic) { var primarySphereOfInfluence = primaryBody.GetGravityVolume().gameObject.GetComponent(); - if (primarySphereOfInfluence.radius < config.Orbit.SemiMajorAxis) - primarySphereOfInfluence.radius = config.Orbit.SemiMajorAxis * 1.5f; + if (primarySphereOfInfluence.radius < config.Orbit.semiMajorAxis) + primarySphereOfInfluence.radius = config.Orbit.semiMajorAxis * 1.5f; } if (config.Orbit.IsTidallyLocked) diff --git a/NewHorizons/Builder/Orbital/InitialMotionBuilder.cs b/NewHorizons/Builder/Orbital/InitialMotionBuilder.cs index 6f152a1f..d10b0e7f 100644 --- a/NewHorizons/Builder/Orbital/InitialMotionBuilder.cs +++ b/NewHorizons/Builder/Orbital/InitialMotionBuilder.cs @@ -108,18 +108,18 @@ namespace NewHorizons.Builder.Orbital } // Update the positions - var distance = secondaryBody.SemiMajorAxis + primaryBody.SemiMajorAxis; + var distance = secondaryBody.semiMajorAxis + primaryBody.semiMajorAxis; var m1 = primaryGravity.Mass; var m2 = secondaryGravity.Mass; var r1 = distance * m2 / (m1 + m2); var r2 = distance * m1 / (m1 + m2); - var ecc = secondaryBody.Eccentricity; - var inc = secondaryBody.Inclination; - var arg = secondaryBody.ArgumentOfPeriapsis; - var lon = secondaryBody.LongitudeOfAscendingNode; - var tru = secondaryBody.TrueAnomaly; + var ecc = secondaryBody.eccentricity; + var inc = secondaryBody.inclination; + var arg = secondaryBody.argumentOfPeriapsis; + var lon = secondaryBody.longitudeOfAscendingNode; + var tru = secondaryBody.trueAnomaly; // Update their astro objects primaryBody.SetOrbitalParametersFromTrueAnomaly(ecc, r1, inc, arg, lon, tru - 180); diff --git a/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs b/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs index 0d494251..d6adef42 100644 --- a/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs +++ b/NewHorizons/Builder/Orbital/OrbitlineBuilder.cs @@ -32,7 +32,7 @@ namespace NewHorizons.Builder.Orbital var numVerts = config.Orbit.DottedOrbitLine ? 128 : 256; lineRenderer.positionCount = numVerts; - var ecc = config.Orbit.Eccentricity; + var ecc = config.Orbit.eccentricity; var parentGravity = astroObject.GetPrimaryBody()?.GetGravityVolume(); @@ -45,12 +45,12 @@ namespace NewHorizons.Builder.Orbital { orbitLine = orbitGO.AddComponent(); - var a = astroObject.SemiMajorAxis; - var e = astroObject.Eccentricity; + var a = astroObject.semiMajorAxis; + var e = astroObject.eccentricity; var b = a * Mathf.Sqrt(1f - (e * e)); - var l = astroObject.LongitudeOfAscendingNode; - var p = astroObject.ArgumentOfPeriapsis; - var i = astroObject.Inclination; + var l = astroObject.longitudeOfAscendingNode; + var p = astroObject.argumentOfPeriapsis; + var i = astroObject.inclination; (orbitLine as NHOrbitLine).SemiMajorAxis = a * OrbitalParameters.Rotate(Vector3.left, l, i, p); (orbitLine as NHOrbitLine).SemiMinorAxis = b * OrbitalParameters.Rotate(Vector3.forward, l, i, p); @@ -84,7 +84,7 @@ namespace NewHorizons.Builder.Orbital orbitLine._lineWidth = 0.2f; - orbitLine._numVerts = (int)Mathf.Clamp(config.Orbit.SemiMajorAxis / 1000f, numVerts, 4096); + orbitLine._numVerts = (int)Mathf.Clamp(config.Orbit.semiMajorAxis / 1000f, numVerts, 4096); Main.Instance.ModHelper.Events.Unity.FireOnNextUpdate(orbitLine.InitializeLineRenderer); diff --git a/NewHorizons/Builder/ShipLog/MapModeBuilder.cs b/NewHorizons/Builder/ShipLog/MapModeBuilder.cs index 8950f14a..59439558 100644 --- a/NewHorizons/Builder/ShipLog/MapModeBuilder.cs +++ b/NewHorizons/Builder/ShipLog/MapModeBuilder.cs @@ -365,7 +365,7 @@ namespace NewHorizons.Builder.ShipLog { foreach (NewHorizonsBody body in bodies.Where(b => b.Config.Base.centerOfSolarSystem)) { - bodies.Sort((b, o) => b.Config.Orbit.SemiMajorAxis.CompareTo(o.Config.Orbit.SemiMajorAxis)); + bodies.Sort((b, o) => b.Config.Orbit.semiMajorAxis.CompareTo(o.Config.Orbit.semiMajorAxis)); MapModeObject newNode = new MapModeObject { mainBody = body, diff --git a/NewHorizons/Components/Orbital/IOrbitalParameters.cs b/NewHorizons/Components/Orbital/IOrbitalParameters.cs index 420e21f9..80838634 100644 --- a/NewHorizons/Components/Orbital/IOrbitalParameters.cs +++ b/NewHorizons/Components/Orbital/IOrbitalParameters.cs @@ -2,12 +2,13 @@ { public interface IOrbitalParameters { - float Inclination { get; set; } - float SemiMajorAxis { get; set; } - float LongitudeOfAscendingNode { get; set; } - float Eccentricity { get; set; } - float ArgumentOfPeriapsis { get; set; } - float TrueAnomaly { get; set; } + // lowercase cuz schema + float inclination { get; set; } + float semiMajorAxis { get; set; } + float longitudeOfAscendingNode { get; set; } + float eccentricity { get; set; } + float argumentOfPeriapsis { get; set; } + float trueAnomaly { get; set; } OrbitalParameters GetOrbitalParameters(Gravity primaryGravity, Gravity secondaryGravity); } diff --git a/NewHorizons/Components/Orbital/NHAstroObject.cs b/NewHorizons/Components/Orbital/NHAstroObject.cs index b16ec603..29c79208 100644 --- a/NewHorizons/Components/Orbital/NHAstroObject.cs +++ b/NewHorizons/Components/Orbital/NHAstroObject.cs @@ -3,38 +3,38 @@ namespace NewHorizons.Components.Orbital { public class NHAstroObject : AstroObject, IOrbitalParameters { - public float Inclination { get; set; } - public float SemiMajorAxis { get; set; } - public float LongitudeOfAscendingNode { get; set; } - public float Eccentricity { get; set; } - public float ArgumentOfPeriapsis { get; set; } - public float TrueAnomaly { get; set; } + public float inclination { get; set; } + public float semiMajorAxis { get; set; } + public float longitudeOfAscendingNode { get; set; } + public float eccentricity { get; set; } + public float argumentOfPeriapsis { get; set; } + public float trueAnomaly { get; set; } public bool HideDisplayName { get; set; } public void SetOrbitalParametersFromConfig(OrbitModule orbit) { - SetOrbitalParametersFromTrueAnomaly(orbit.Eccentricity, orbit.SemiMajorAxis, orbit.Inclination, orbit.ArgumentOfPeriapsis, orbit.LongitudeOfAscendingNode, orbit.TrueAnomaly); + SetOrbitalParametersFromTrueAnomaly(orbit.eccentricity, orbit.semiMajorAxis, orbit.inclination, orbit.argumentOfPeriapsis, orbit.longitudeOfAscendingNode, orbit.trueAnomaly); } public void SetOrbitalParametersFromTrueAnomaly(float ecc, float a, float i, float p, float l, float trueAnomaly) { - Inclination = ecc; - SemiMajorAxis = a; - LongitudeOfAscendingNode = l; - Inclination = i; - Eccentricity = ecc; - ArgumentOfPeriapsis = p; - TrueAnomaly = trueAnomaly; + inclination = ecc; + semiMajorAxis = a; + longitudeOfAscendingNode = l; + inclination = i; + eccentricity = ecc; + argumentOfPeriapsis = p; + this.trueAnomaly = trueAnomaly; } public override string ToString() { - return $"ParameterizedAstroObject: Eccentricity {Eccentricity}, SemiMajorAxis {SemiMajorAxis}, Inclination {Inclination}, ArgumentOfPeriapsis {ArgumentOfPeriapsis}, LongitudeOfAscendingNode {LongitudeOfAscendingNode}, TrueAnomaly {TrueAnomaly}"; + return $"ParameterizedAstroObject: Eccentricity {eccentricity}, SemiMajorAxis {semiMajorAxis}, Inclination {inclination}, ArgumentOfPeriapsis {argumentOfPeriapsis}, LongitudeOfAscendingNode {longitudeOfAscendingNode}, TrueAnomaly {trueAnomaly}"; } public OrbitalParameters GetOrbitalParameters(Gravity primaryGravity, Gravity secondaryGravity) { - return OrbitalParameters.FromTrueAnomaly(primaryGravity, secondaryGravity, Eccentricity, SemiMajorAxis, Inclination, ArgumentOfPeriapsis, LongitudeOfAscendingNode, TrueAnomaly); + return OrbitalParameters.FromTrueAnomaly(primaryGravity, secondaryGravity, eccentricity, semiMajorAxis, inclination, argumentOfPeriapsis, longitudeOfAscendingNode, trueAnomaly); } } } diff --git a/NewHorizons/Components/Orbital/OrbitalParameters.cs b/NewHorizons/Components/Orbital/OrbitalParameters.cs index f7a3bf3a..4cbd2e5b 100644 --- a/NewHorizons/Components/Orbital/OrbitalParameters.cs +++ b/NewHorizons/Components/Orbital/OrbitalParameters.cs @@ -4,12 +4,12 @@ namespace NewHorizons.Components.Orbital { public class OrbitalParameters : IOrbitalParameters { - public float Inclination { get; set; } - public float SemiMajorAxis { get; set; } - public float LongitudeOfAscendingNode { get; set; } - public float Eccentricity { get; set; } - public float ArgumentOfPeriapsis { get; set; } - public float TrueAnomaly { get; set; } + public float inclination { get; set; } + public float semiMajorAxis { get; set; } + public float longitudeOfAscendingNode { get; set; } + public float eccentricity { get; set; } + public float argumentOfPeriapsis { get; set; } + public float trueAnomaly { get; set; } public float Period { get; set; } public Vector3 InitialPosition { get; private set; } @@ -19,11 +19,11 @@ namespace NewHorizons.Components.Orbital public static OrbitalParameters FromTrueAnomaly(Gravity primaryGravity, Gravity secondaryGravity, float eccentricity, float semiMajorAxis, float inclination, float argumentOfPeriapsis, float longitudeOfAscendingNode, float trueAnomaly) { var orbitalParameters = new OrbitalParameters(); - orbitalParameters.Inclination = inclination; - orbitalParameters.SemiMajorAxis = semiMajorAxis; - orbitalParameters.LongitudeOfAscendingNode = longitudeOfAscendingNode; - orbitalParameters.Eccentricity = eccentricity; - orbitalParameters.ArgumentOfPeriapsis = argumentOfPeriapsis; + orbitalParameters.inclination = inclination; + orbitalParameters.semiMajorAxis = semiMajorAxis; + orbitalParameters.longitudeOfAscendingNode = longitudeOfAscendingNode; + orbitalParameters.eccentricity = eccentricity; + orbitalParameters.argumentOfPeriapsis = argumentOfPeriapsis; // If primary gravity is linear and the orbit is eccentric its not even an ellipse so theres no true anomaly if (primaryGravity.Power == 1 && eccentricity != 0) @@ -31,7 +31,7 @@ namespace NewHorizons.Components.Orbital trueAnomaly = 0; } - orbitalParameters.TrueAnomaly = trueAnomaly; + orbitalParameters.trueAnomaly = trueAnomaly; // Have to calculate the rest @@ -110,7 +110,7 @@ namespace NewHorizons.Components.Orbital public OrbitalParameters GetOrbitalParameters(Gravity primaryGravity, Gravity secondaryGravity) { - return FromTrueAnomaly(primaryGravity, secondaryGravity, Eccentricity, SemiMajorAxis, Inclination, ArgumentOfPeriapsis, LongitudeOfAscendingNode, TrueAnomaly); + return FromTrueAnomaly(primaryGravity, secondaryGravity, eccentricity, semiMajorAxis, inclination, argumentOfPeriapsis, longitudeOfAscendingNode, trueAnomaly); } } } diff --git a/NewHorizons/Components/QuantumPlanet.cs b/NewHorizons/Components/QuantumPlanet.cs index 4b932df9..ff5f283b 100644 --- a/NewHorizons/Components/QuantumPlanet.cs +++ b/NewHorizons/Components/QuantumPlanet.cs @@ -79,7 +79,7 @@ namespace NewHorizons.Components // Figure out what the new orbit will be if we switch var newOrbit = newState.orbit ?? groundState.orbit; - newOrbit.TrueAnomaly = Random.Range(0f, 360f); + newOrbit.trueAnomaly = Random.Range(0f, 360f); primaryBody = AstroObjectLocator.GetAstroObject(newOrbit.PrimaryBody); var primaryGravity = new Gravity(primaryBody.GetGravityVolume()); @@ -131,7 +131,7 @@ namespace NewHorizons.Components _detector._activeVolumes = new List() { primaryBody.GetGravityVolume() }; if (_alignment != null) _alignment.SetTargetBody(primaryBody.GetComponent()); - _astroObject.SetOrbitalParametersFromTrueAnomaly(orbitalParameters.Eccentricity, orbitalParameters.SemiMajorAxis, orbitalParameters.Inclination, orbitalParameters.ArgumentOfPeriapsis, orbitalParameters.LongitudeOfAscendingNode, orbitalParameters.TrueAnomaly); + _astroObject.SetOrbitalParametersFromTrueAnomaly(orbitalParameters.eccentricity, orbitalParameters.semiMajorAxis, orbitalParameters.inclination, orbitalParameters.argumentOfPeriapsis, orbitalParameters.longitudeOfAscendingNode, orbitalParameters.trueAnomaly); PlanetCreationHandler.UpdatePosition(gameObject, orbitalParameters, primaryBody, _astroObject); diff --git a/NewHorizons/External/Modules/OrbitModule.cs b/NewHorizons/External/Modules/OrbitModule.cs index 7b255e98..a3c4bb5a 100644 --- a/NewHorizons/External/Modules/OrbitModule.cs +++ b/NewHorizons/External/Modules/OrbitModule.cs @@ -66,40 +66,40 @@ namespace NewHorizons.External.Modules /// /// The semi-major axis of the ellipse that is the body's orbit. For a circular orbit this is the radius. /// - public float SemiMajorAxis { get; set; } + public float semiMajorAxis { get; set; } /// /// The angle (in degrees) between the body's orbit and the plane of the star system /// - public float Inclination { get; set; } + public float inclination { get; set; } /// /// An angle (in degrees) defining the point where the orbit of the body rises above the orbital plane if it has /// nonzero inclination. /// - public float LongitudeOfAscendingNode { get; set; } + public float longitudeOfAscendingNode { get; set; } /// /// At 0 the orbit is a circle. The closer to 1 it is, the more oval-shaped the orbit is. /// // FIXME: Needs Min & Max! - public float Eccentricity { get; set; } + public float eccentricity { get; set; } /// /// An angle (in degrees) defining the location of the periapsis (the closest distance to it's primary body) if it has /// nonzero eccentricity. /// - public float ArgumentOfPeriapsis { get; set; } + public float argumentOfPeriapsis { get; set; } /// /// Where the planet should start off in its orbit in terms of the central angle. /// - public float TrueAnomaly { get; set; } + public float trueAnomaly { get; set; } public OrbitalParameters GetOrbitalParameters(Gravity primaryGravity, Gravity secondaryGravity) { - return OrbitalParameters.FromTrueAnomaly(primaryGravity, secondaryGravity, Eccentricity, SemiMajorAxis, - Inclination, ArgumentOfPeriapsis, LongitudeOfAscendingNode, TrueAnomaly); + return OrbitalParameters.FromTrueAnomaly(primaryGravity, secondaryGravity, eccentricity, semiMajorAxis, + inclination, argumentOfPeriapsis, longitudeOfAscendingNode, trueAnomaly); } } } \ No newline at end of file diff --git a/NewHorizons/Handlers/PlanetCreationHandler.cs b/NewHorizons/Handlers/PlanetCreationHandler.cs index ff132224..d9cd5e70 100644 --- a/NewHorizons/Handlers/PlanetCreationHandler.cs +++ b/NewHorizons/Handlers/PlanetCreationHandler.cs @@ -187,7 +187,7 @@ namespace NewHorizons.Handlers if (sector.transform.childCount == 0) sector = quantumPlanet.groundState.sector; // If semimajor axis is 0 then forget the orbit - var orbit = body.Config.Orbit.SemiMajorAxis == 0 ? quantumPlanet.groundState.orbit : body.Config.Orbit; + var orbit = body.Config.Orbit.semiMajorAxis == 0 ? quantumPlanet.groundState.orbit : body.Config.Orbit; quantumPlanet.states.Add(new QuantumPlanet.State(sector, orbit)); } @@ -243,7 +243,7 @@ namespace NewHorizons.Handlers var rb = go.GetAttachedOWRigidbody(); // Since orbits are always there just check if they set a semi major axis - if (body.Config.Orbit != null && body.Config.Orbit.SemiMajorAxis != 0f) + if (body.Config.Orbit != null && body.Config.Orbit.semiMajorAxis != 0f) { UpdateBodyOrbit(body, go); }