Gittes-archive/AssetRipper_AssetRipper
2
0
Fork 0
mirror of https://github.com/AssetRipper/AssetRipper.git synced 2025-12-11 20:15:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor audio conversion and enhance playback experience

Browse Source 
Updated `AudioConverter` to streamline null checks and return empty arrays. Added OGG to WAV conversion in `AssetAPI` for better audio handling. Modified `AudioTab` to preload audio automatically, improving user experience.

Related: #1877
This commit is contained in:
ds5678 2025-08-04 12:17:28 -07:00
parent 206f0ec99b
commit 645ed5a336
3 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Source/AssetRipper.Export.Modules.Audio/AudioConverter.cs
View File

@ -8,14 +8,11 @@ public static class AudioConverter
{
public static byte[] OggToWav(byte[] oggData)
{
if (oggData == null)
{
throw new ArgumentNullException(nameof(oggData));
}
ArgumentNullException.ThrowIfNull(oggData);
if (oggData.Length == 0)
{
return Array.Empty<byte>();
return [];
}
try
@ -28,7 +25,7 @@ public static class AudioConverter
catch (Exception ex)
{
Logger.Error(LogCategory.Export, "Failed to convert audio from OGG to WAV", ex);
return Array.Empty<byte>();
return [];
}
}
}

9
Source/AssetRipper.GUI.Web/Pages/Assets/AssetAPI.cs
View File

@ -181,6 +181,15 @@ internal static class AssetAPI
}
else if (AudioClipDecoder.TryDecode(clip, out byte[]? decodedAudioData, out string? extension, out _))
{
if (extension is "ogg")
{
byte[] wavData = AudioConverter.OggToWav(decodedAudioData);
if (wavData.Length > 0)
{
decodedAudioData = wavData;
extension = "wav";
}
}
return Results.Bytes(decodedAudioData, $"audio/{extension}").ExecuteAsync(context);
}
else

2
Source/AssetRipper.GUI.Web/Pages/Assets/AudioTab.cs
View File

@ -28,7 +28,7 @@ internal sealed class AudioTab : AssetHtmlTab
{
using (new Td(writer).WithAlign("center").WithCustomAttribute("valign", "middle").End())
{
new Audio(writer).WithControls("").WithClass("mt-4").WithSrc(Source).Close();
new Audio(writer).WithControls("").WithPreload("auto").WithClass("mt-4").WithSrc(Source).Close();
}
}
}